Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update formula_creator.rb #19173

Merged
merged 3 commits into from
Feb 1, 2025

Conversation

BingoKingo
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! A bit more discussion and this will be ready to merge.

Library/Homebrew/formula_creator.rb Outdated Show resolved Hide resolved
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Feb 1, 2025
Merged via the queue into Homebrew:master with commit b162acc Feb 1, 2025
28 checks passed
gromgit added a commit to gromgit/homebrew-brew that referenced this pull request Feb 5, 2025
Followup to Homebrew#19173, which causes `brew create` to error out on the literal `[email protected]` dependency.

Related to Homebrew#19240.
gromgit added a commit to gromgit/homebrew-brew that referenced this pull request Feb 5, 2025
Followup to Homebrew#19173, which causes `brew create` to error out on the literal `[email protected]` dependency.

Related to Homebrew#19240.
gromgit added a commit to gromgit/homebrew-brew that referenced this pull request Feb 5, 2025
Followup to Homebrew#19173, which causes `brew create` to error out on the literal `[email protected]` dependency.

Related to Homebrew#19240.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants