Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exec: support nodenv, pyenv and rbenv #1444

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

carlocab
Copy link
Member

@carlocab carlocab commented Sep 7, 2024

If nodenv, pyenv, or rbenv are in the Brewfile, let's add their
shims directory to PATH during brew bundle exec.

This makes it so that brew bundle exec just works without relying on
the user adding the required node/python3/ruby formula to their
Brewfile and then doing brew *env-sync.

If `nodenv`, `pyenv`, or `rbenv` are in the `Brewfile`, let's add their
`shims` directory to `PATH` during `brew bundle exec`.

This makes it so that `brew bundle exec` just works without relying on
the user adding the required `node`/`python3`/`ruby` formula to their
`Brewfile` and then doing `brew *env-sync`.
@jacobbednarz
Copy link
Member

i like the intention here however, it seems like we may be playing a game of whack a mole with all version managers that rely on shims. should we expand the coverage for more tools upfront?

@carlocab
Copy link
Member Author

carlocab commented Sep 7, 2024

I'd rather not. These are the version managers that are well-integrated with brew given that they have supporting built-in commands:

Other version managers not only aren't integrated as well with brew, and some also don't support usage through brew.

To avoid the whack-a-mole, we can probably draw the line at anything that already has native brew integration.

@jacobbednarz
Copy link
Member

sounds great, thanks @carlocab

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carlocab Thanks! Let's not go much further in this direction, though; don't want Brewfile scope to expand too much.

@MikeMcQuaid MikeMcQuaid merged commit 753199d into Homebrew:master Sep 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants