-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
marginnote 4.1.4 #185753
base: master
Are you sure you want to change the base?
marginnote 4.1.4 #185753
Conversation
upgrade Marginnote4.14
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your first contribution to homebrew-cask
, @foreverangelwing! 🎉
There are still a few minor issues to address:
We should continue using interpolation for the version rather than hardcoding it in other stanzas. The placeholder #{version.major}
will be replaced by the major version (e.g., 4) during evaluation.
Please also squash your commits to maintain a cleaner history.
@@ -1,22 +1,22 @@ | |||
cask "marginnote" do | |||
version "3.7.25" | |||
sha256 "4409e29b6046fc71442f3f2085375dada87b3f06a90892b2334823b0dad75ad3" | |||
version "4.14" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
version "4.14" | |
version "4.1.4" |
|
||
url "https://marginstudy.com/mac/MarginNote#{version.major}.dmg", | ||
verified: "marginstudy.com/mac/" | ||
url "https://d.marginnote.cn/MarginNote4.dmg", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
url "https://d.marginnote.cn/MarginNote4.dmg", | |
url "https://dist.marginnote.cn/MarginNote#{version}.dmg", |
name "MarginNote" | ||
desc "E-reader" | ||
homepage "https://www.marginnote.com/" | ||
|
||
livecheck do | ||
url "https://dist.marginnote.cn/marginnote#{version.major}.xml" | ||
url "https://dist.marginnote.cn/marginnote4.xml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
url "https://dist.marginnote.cn/marginnote4.xml" | |
url "https://dist.marginnote.cn/marginnote#{version.major}.xml" |
strategy :sparkle, &:short_version | ||
end | ||
|
||
auto_updates true | ||
depends_on macos: ">= :sierra" | ||
depends_on macos: ">= :sequoia" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
depends_on macos: ">= :sequoia" | |
depends_on macos: ">= :monterey" |
|
||
app "MarginNote #{version.major}.app" | ||
app "MarginNote 4.app" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
app "MarginNote 4.app" | |
app "MarginNote #{version.major}.app" |
Description
This pull request updates the Homebrew Cask for MarginNote from version 3.7.25 to version 4.14.
Changes:
version
to4.14
url
tohttps://d.marginnote.cn/MarginNote4.dmg
app
target toMarginNote 4.app
sha256
to the new checksum for the updated dmg filelivecheck
URL tohttps://dist.marginnote.cn/marginnote4.xml
Reason for the Update:
MarginNote has released version 4.14 with new features and improvements. This update reflects the latest available version to ensure users can download and use the most current release.
Let me know if further modifications or corrections are needed. Thanks for reviewing!