-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
semeru-jdk-open 23+37 #185890
base: master
Are you sure you want to change the base?
semeru-jdk-open 23+37 #185890
Conversation
3d5e486
to
a039ab5
Compare
I believe I've fixes all the errors I can. Let me know if there's anything else or if I need to squash my commits. |
Casks/s/[email protected]
Outdated
@@ -0,0 +1,27 @@ | |||
cask "semeru-jdk-open@22" do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this still be supported upstream?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, 22.0.2.1 (22.0.2+9) is the last release. Shall I remove this then? Technically it is still a "secure" level until the Oct CPU releases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I would say we can just drop it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. Should I backport the changes into any of the previous versions or just leave them in the latest rb?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what changes you mean, but if you have improvements for older releases let's do that in a separate PR.
Switch to 3 version fields to support initial GA releases. Signed-off-by: Adam Brousseau <[email protected]>
a039ab5
to
5f0ebe3
Compare
Move 22 to a new rb file
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
In the following questions
<cask>
is the token of the cask you're submitting.After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>
is error-free.brew style --fix <cask>
reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>
worked successfully.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>
worked successfully.brew uninstall --cask <cask>
worked successfully.