Handle broken symlinks on install, install --force
#21893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an error occurring with both `install` and `install --force` where either would fail when encountering a broken symlink. Users _might_ run into that issue in the wake of PR #21857, and certainly _will_ be bitten by it once PR #21858 is merged. This commit changes the `install` case so it handles the condition gracefully. It also fixes `install --force` so before moving an app, it removes any broken symlinks which might stand in the way.
claui
added
bug
|
Great work once again, @claui 😄 |
jawshooah
removed
the
awaiting maintainer feedback
|
Thanks @jawshooah 😊 |
chizmw
pushed a commit
to chizmw/homebrew-cask
that referenced
this pull request
Jun 15, 2016
This commit fixes an error occurring with both `install` and `install --force` where either would fail when encountering a broken symlink. Users _might_ run into that issue in the wake of PR Homebrew#21857, and certainly _will_ be bitten by it once PR Homebrew#21858 is merged. This commit changes the `install` case so it handles the condition gracefully. It also fixes `install --force` so before moving an app, it removes any broken symlinks which might stand in the way.
miccal
removed
bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing PR #21857 earlier today, I have found that
brew cask installfails when it encounters a broken symlink, no matter if with or without--force:Users might run into this in the wake of PR #21857, e. g. trying to move their Caskrooms around in an attempt to get
brew cask listback working, or to merge their Caskrooms. One could argue that users are not supposed to do this, but we all know they will do it anyway. The issue will also bite unsuspecting users once PR #21858 is merged. Any legacy (pre-#13966) symlink pointing inside a custom Caskroom location is likely going to break.I feel that while
installneeds to fail gracefully,install --forceshould do exactly what it says on the tin and sweep broken symlinks out of the way.This PR fixes both the
installandinstall --forcecase.Note that the
uninstallandzapcases have similar issues; those remain unfixed for the time being. Those cases have additional issues anyway, require a bit more effort to be fixed, and thus deserve a PR on their own.