Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redocument the artifact stanza per #13966 #25290

Merged
merged 1 commit into from
Oct 7, 2016
Merged

Redocument the artifact stanza per #13966 #25290

merged 1 commit into from
Oct 7, 2016

Conversation

leee
Copy link
Contributor

@leee leee commented Oct 7, 2016

If there’s a checkbox you can’t complete for any reason, that's okay, just explain in detail why you weren’t able to do so.

After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} reports no offenses.
  • The commit message includes the cask’s name and version.

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • brew cask install {{cask_file}} worked successfully.
  • brew cask uninstall {{cask_file}} worked successfully.
  • Checked there are no open pull requests for the same cask.
  • Checked that the cask was not already refused in closed issues.

None of these checks apply to this PR.

CONTRIBUTING.md should probably mention how to contribute things other than casks.

I spent over an hour trying to figure out why this stanza was not behaving with a cask I was developing as expected until I found #13966 and then #13201.

I spent over an hour trying to figure out why this stanza was not behaving with a cask I was developing as expected until I found #13966 and then #13201.
@vitorgalvao vitorgalvao merged commit bbced43 into Homebrew:master Oct 7, 2016
@leee leee deleted the patch-1 branch October 7, 2016 09:36
@Homebrew Homebrew locked and limited conversation to collaborators May 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants