Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Homespun Instant Access v2.9.3 #42319

Merged
merged 2 commits into from
Dec 29, 2017
Merged

Add Homespun Instant Access v2.9.3 #42319

merged 2 commits into from
Dec 29, 2017

Conversation

laenzlinger
Copy link
Contributor

Homespun is a music instruction site.
Homespun Instant Access is the application to play Homespun lessons.

I am not sure if I implemented this cask correctly. The Application requires an installer script to be run. I was able to start this script, but It still requires manual input (clicks) from the user. (First a confirmation and then a screen to accept the license agreement)

screen shot 2017-12-27 at 19 55 52

screen shot 2017-12-27 at 19 56 15

After making all changes to the cask:

  • brew cask audit --download {{cask_file}} is error-free.
  • brew cask style --fix {{cask_file}} reports no offenses.
  • The commit message includes the cask’s name and version.

Additionally, if adding a new cask:

  • Named the cask according to the [token reference].
  • brew cask install {{cask_file}} worked successfully.
  • brew cask uninstall {{cask_file}} worked successfully.
  • Checked there are no [open pull requests] for the same cask.
  • Checked the cask was not already refused in [closed issues].
  • Checked the cask is submitted to [the correct repo].

Homespun is a music instruction site.
Homespun Instant Access is the application to play Homespun lessions.
}

uninstall quit: 'com..mm_launcher',
delete: '/Applications/Homespun Instant Access.app'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure adding this app is the only thing the installer does? That is highly unlikely.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you, that probably it does something very strange (since it requires password during the installation.

How can I find out what the application is installing?

I am using app cleaner to remove applications: This reports the following:
screen shot 2017-12-27 at 21 01 59

What out of this data should be removed? Something more?

sudo: true,
}

uninstall quit: 'com..mm_launcher',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct (..)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately this seems to be the id of this bundle. See the following output while the application is running:

/u/l/H/L/T/c/homebrew-cask ❯❯❯ developer/bin/list_running_app_ids                                                                   bundle_id	app_name
--------------------------------------
.... more stuff
com..mm_launcher	Homespun Instant Access
.... more stuff

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s fine if it is, I was just checking if it wasn’t a copying mistake.

homepage 'https://www.homespun.com/direct-download/'

installer script: {
executable: "#{staged_path}/Homespun Instant Access Installer.app/Contents/MacOS/Homespun Instant Access Installer",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn’t a script, it’s simply the binary inside the app bundle.

This need to be installer manual: on the .app instead.

Copy link
Contributor Author

@laenzlinger laenzlinger Dec 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried manual as well. But I was not sure, how such situation is usually handled. I thought it was beneficial to the user would not have to locate the installer manually and click on it, instead, I thought it would be easier that the installer ist automatically started.

But I am new to this project and I have not seen many different casks how the work.

If I get you correctly, a manual installation is the best for such situation, therefore I will change it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it was beneficial to the user would not have to locate the installer manually and click on it, instead, I thought it would be easier that the installer ist automatically started.

But that also means the installation blocks scripts (much like it did Travis), which is bad. This is standard procedure for us, and users already expect it.

We do have plans for it to be different in the future — see #24377.

Copy link
Contributor Author

@laenzlinger laenzlinger Dec 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, I will update this PR. I fully understand that Travis has to succeed.

installer manual: 'Homespun Instant Access Installer.app'

uninstall quit: 'com..mm_launcher',
delete: '/Applications/Homespun Instant Access.app'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can I find out what the application is installing?

Ideally, the developer will have that information somewhere, like instructions on how to completely uninstall the app.

But you can also take a look at our other developer/bin scripts, namely list_installed_launchjob_ids, list_loaded_kext_ids. They might turn up something more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked both list_loaded_kext_ids and list_installed_launchjob_ids . Both did not report anything related to this application.

Unfortunately I am not the developer of the Homespun application. (Just a user)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not the developer of the Homespun application.

I know, but the information may be posted somewhere on the website or there may be a forum where you can ask.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, I was searching a bit on the webpage. But definitely a good Idea is the forum (although it's a bit music related, but maybe somebody is willing to help)

Copy link
Contributor Author

@laenzlinger laenzlinger Dec 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently checking with the support....

screen shot 2017-12-27 at 22 14 27

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for checking!

@vitorgalvao vitorgalvao merged commit b3b1cd9 into Homebrew:master Dec 29, 2017
@laenzlinger laenzlinger deleted the add-homespun-instant-access branch December 30, 2017 01:39
@Homebrew Homebrew locked and limited conversation to collaborators May 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants