Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update teamviewer, teamviewer-host: remove uninstall #45718

Merged
merged 2 commits into from
Apr 9, 2018
Merged

Update teamviewer, teamviewer-host: remove uninstall #45718

merged 2 commits into from
Apr 9, 2018

Conversation

commitay
Copy link
Contributor

@commitay commitay commented Apr 9, 2018

Fixes #15322 (comment)

Different issue than originally reported in #15322

@commitay
Copy link
Contributor Author

commitay commented Apr 9, 2018

@TravisBuddy stop

@commitay
Copy link
Contributor Author

commitay commented Apr 9, 2018

@vitorgalvao 55ae7b0 fixes the issue but any upstream changes to the pkgs (i.e. the files within com.teamviewer.teamviewer13AuthPlugin are added to a pkg id that we uninstall) will cause further issues. I think removing the uninstall altogether is the safest option.

@vitorgalvao
Copy link
Member

I think removing the uninstall altogether is the safest option.

Agreed.

@vitorgalvao
Copy link
Member

Added both casks to #24377.

@commitay commitay changed the title Update teamviewer, teamviewer-host: uninstall Update teamviewer, teamviewer-host: remove uninstall Apr 9, 2018
@commitay commitay merged commit 81fd124 into Homebrew:master Apr 9, 2018
@commitay commitay deleted the teamviewer branch April 9, 2018 12:33
@lock lock bot locked as resolved and limited conversation to collaborators Jul 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@commitay @vitorgalvao