Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esphome: add python-setuptools depedency #191315

Merged

Conversation

bobsoppe
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

When trying to compile some configuration with ESPHome, an error is thrown for missing the pkg_resources module. Adding the python-setuptools depedency will fix this issue.

An issue upstream is open for some time already: esphome/firmware#235

@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. python Python use is a significant feature of the PR or issue labels Sep 20, 2024
When compiling a configuration which uses esp-idf, the `pkg_resources`
module is missing. Adding the `python-setuptools` dependency will fix
this issue
@bobsoppe bobsoppe force-pushed the add-esphome-setuptools-depedency branch from 9c184da to 70157e5 Compare September 20, 2024 07:54
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Sep 20, 2024
@carlocab carlocab changed the title Add python-setuptools depedency for ESPHome esphome: add python-setuptools depedency Sep 20, 2024
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Sep 20, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Sep 20, 2024
Merged via the queue into Homebrew:master with commit 766c57f Sep 20, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. python Python use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants