Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

whisper-cpp: make compatible with --HEAD install #202270

Merged
merged 2 commits into from
Dec 26, 2024

Conversation

mislav
Copy link
Contributor

@mislav mislav commented Dec 23, 2024

This is to accommodate the build system changes in the upcoming v1.7.4 release.

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

In --HEAD mode, the main changes are that dylibs are now enabled and that the main binary is now called whisper-cli.

Libraries and header files currently unfortunately conflict with the llama.cpp formula, so in this installation we rename the "lib" folder and omit the header files to avoid the conflict. ggml-org/ggml#1050 (comment)

This is to accommodate the build system changes in the upcoming v1.7.4
@mislav
Copy link
Contributor Author

mislav commented Dec 25, 2024

@carlocab Thanks for the detailed review; I've addressed the comments.

Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Dec 26, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Dec 26, 2024
Merged via the queue into Homebrew:master with commit 1dfaea4 Dec 26, 2024
15 checks passed
@mislav mislav deleted the whisper-cpp-head branch December 27, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants