icann-rdap 0.0.21 (new formula) #205514
Merged
icann-rdap 0.0.21 (new formula) #205514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
automerge-skip
|
Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request. |
daeho-ro
reviewed
Jan 26, 2025
daeho-ro
changed the title
|
I need to clean this up according to the suggestions, split the commit, and retest. |
|
The commits need to squash with force push. |
This is a new formula for the icann-rdap command line RDAP client. This formula uses the Rust build system and specifies a path for the icann-rdap-cli crate. This formula installs two binaries: rdap and rdap-test.
github-actions
bot
added
autosquash
daeho-ro
approved these changes
Jan 27, 2025
|
The commit style check is failing. I think I put the wrong title on the second commit and it should have been "rdap: adds conflict between rdap and icann-rdap" (i.e. starts with "rdap:"). Would you like me to rewrite the commit message? |
Both formula install an rdap executable binary and are therefore in conflict. This commit adds the conflict to rdap while the conflict is in icann-rdap in another commit.
github-actions
bot
removed
the
autosquash
daeho-ro
approved these changes
Feb 2, 2025
|
Thank you, @anewton1998 ! |
github-actions
bot
added
the
CI-published-bottle-commits
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?