-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ryelang: rename binary; rye: update homepage, add successor & conflict #205578
base: master
Are you sure you want to change the base?
Conversation
ec5ddef
to
611e012
Compare
611e012
to
c42a8b6
Compare
c42a8b6
to
6643917
Compare
Is there a way to convey the official message
Which is stated on the https://rye.astral.sh/ homepage and in repository README? Does that mean it is deprecated while it is still maintained? Or should it be mentioned in the description? |
You can do |
as rye is still actively maintained, we dont have any way to convey the successor information, might be good to leave as a code comment? |
6643917
to
f34df27
Compare
I have chosen to add
to the visible formula description, as they are also prominently encouraging (on homepage & in readme) their users to do so. |
8460964
to
57d71ee
Compare
I think we should ask upstream, but:
|
yeah, might be good to raise an issue as well to push things a bit, otherwise lgtm. |
@charliermarsh, can you help us understand the status of Rye? Deprecating would not disable it entirely
More on that: https://docs.brew.sh/Deprecating-Disabling-and-Removing-Formulae |
Sure thing. We don't consider Rye to be deprecated. We will likely deprecate it at some point in the future, but today, it's still maintained and we still cut new releases (with all major new development happening in uv). From my perspective it's a bit early to mark it as deprecated in Homebrew, but could make sense to do so at some point in the future. |
57d71ee
to
176d994
Compare
Thansk @charliermarsh for the clarification. |
No, that sounds great, thanks @stefanb! |
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?Binary name
rye
now matches documentation at https://ryelang.org/cookbook/using_rye/executable/ (and other places).Naming conflict is known: refaktor/rye#190
The conflicting formula
rye
has nominated a successor formulauv
.