Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ryelang: rename binary; rye: update homepage, add successor & conflict #205578

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

stefanb
Copy link
Member

@stefanb stefanb commented Jan 26, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Binary name rye now matches documentation at https://ryelang.org/cookbook/using_rye/executable/ (and other places).
Naming conflict is known: refaktor/rye#190
The conflicting formula rye has nominated a successor formula uv.

@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Jan 26, 2025
@stefanb stefanb force-pushed the ryelang-rye-binary branch from ec5ddef to 611e012 Compare January 26, 2025 21:04
@github-actions github-actions bot removed the automerge-skip `brew pr-automerge` will skip this pull request label Jan 26, 2025
@stefanb stefanb force-pushed the ryelang-rye-binary branch from 611e012 to c42a8b6 Compare January 27, 2025 06:30
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Jan 27, 2025
@stefanb stefanb force-pushed the ryelang-rye-binary branch from c42a8b6 to 6643917 Compare January 27, 2025 06:35
@github-actions github-actions bot removed the automerge-skip `brew pr-automerge` will skip this pull request label Jan 27, 2025
@stefanb
Copy link
Member Author

stefanb commented Jan 27, 2025

Is there a way to convey the official message

consider uv, the successor project?

Which is stated on the https://rye.astral.sh/ homepage and in repository README? Does that mean it is deprecated while it is still maintained? Or should it be mentioned in the description?

@SMillerDev
Copy link
Member

You can do deprecate! date: "YYYY-MM-DD", because: :reason, replacement: "foo"

@chenrui333
Copy link
Member

as rye is still actively maintained, we dont have any way to convey the successor information, might be good to leave as a code comment?

@stefanb stefanb force-pushed the ryelang-rye-binary branch from 6643917 to f34df27 Compare January 27, 2025 16:35
@stefanb stefanb changed the title ryelang: rename binary to documented "rye" ryelang: rename binary to documented "rye"; rye: update homepage, add successor & conflict Jan 27, 2025
@stefanb stefanb changed the title ryelang: rename binary to documented "rye"; rye: update homepage, add successor & conflict ryelang: rename binary; rye: update homepage, add successor & conflict Jan 27, 2025
@stefanb
Copy link
Member Author

stefanb commented Jan 27, 2025

I have chosen to add

Consider the successor "uv" instead.

to the visible formula description, as they are also prominently encouraging (on homepage & in readme) their users to do so.

@stefanb stefanb force-pushed the ryelang-rye-binary branch 3 times, most recently from 8460964 to 57d71ee Compare January 27, 2025 17:00
@SMillerDev
Copy link
Member

as rye is still actively maintained, we dont have any way to convey the successor information, might be good to leave as a code comment?

I think we should ask upstream, but:

  • deprecated doesn't mean unmaintained, so maintained doesn't factor into this one
  • they clearly mean for people to switch to uv, so we should probably help
  • the description is a lot less clear than a deprecation warning

@chenrui333
Copy link
Member

yeah, might be good to raise an issue as well to push things a bit, otherwise lgtm.

@stefanb
Copy link
Member Author

stefanb commented Jan 29, 2025

@charliermarsh, can you help us understand the status of Rye?
Q: Should we deprecate it here in Homebrew core to encourage users to migrate to uv?

Deprecating would not disable it entirely

  • deprecate: formula should no longer be used
  • disable: formula cannot be used

More on that: https://docs.brew.sh/Deprecating-Disabling-and-Removing-Formulae

@charliermarsh
Copy link
Contributor

Sure thing. We don't consider Rye to be deprecated. We will likely deprecate it at some point in the future, but today, it's still maintained and we still cut new releases (with all major new development happening in uv).

From my perspective it's a bit early to mark it as deprecated in Homebrew, but could make sense to do so at some point in the future.

@stefanb stefanb force-pushed the ryelang-rye-binary branch from 57d71ee to 176d994 Compare January 30, 2025 07:21
@stefanb
Copy link
Member Author

stefanb commented Jan 30, 2025

Thansk @charliermarsh for the clarification.
Based on that I propose to keep it active (not deprecate!d) and adding a short note " (consider the successor "uv" instead)" into description, as it is currently in this PR. If you think mentioning "successor" is too harsh we can revert or rephrase that too.

@charliermarsh
Copy link
Contributor

No, that sounds great, thanks @stefanb!

@stefanb stefanb added the ready to merge PR can be merged once CI is green label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
homepage ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants