Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fricas 1.3.11 (new formula) #205760

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fricas 1.3.11 (new formula) #205760

wants to merge 1 commit into from

Conversation

oldk1331
Copy link

Hi, I'm a developer of FriCAS, and I hope to use homebrew as the default distribution method instead of CI-built unsigned dmg. (fricas is mainly a CLI application, although it also has an ancient looking X11 GUI.)

So this PR is a revival of #156570, it seems that the problem with that PR is CI runs took too much time and build failure under Linux.

I removed ENV.deparallelize to make the build parallel because I see no reason why it can't. Also I did the following local testing under linux.

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added the new formula PR adds a new formula to Homebrew/homebrew-core label Jan 28, 2025
Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

Formula/f/fricas.rb Outdated Show resolved Hide resolved
@oldk1331 oldk1331 force-pushed the fricas branch 2 times, most recently from 73f88b2 to 1c93ed3 Compare January 28, 2025 12:06
@oldk1331
Copy link
Author

I did a search of sbcl.core in this repo, and I find that this is a known issue:

# Fails in Linux CI with "Can't find sbcl.core"
# Fails in Linux CI with "Can't find sbcl.core"
# Fails in Linux CI with "Can't find sbcl.core"

Seems that in the CI environment, homebrew strips the binary? Anyway, I copied the workaround, and let's see the result.

@oldk1331
Copy link
Author

OK, 2 updates:

  1. The binary is stripped due to Reproducible builds for native compiled binaries brew#16860 I guess, any ways to disable it other than shims/super/cc: don't strip prefixes with --debug-symbols brew#18331?
  2. The build stalls on arm macOS because the default 3GB dynamic space size is not enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants