asdf 0.16.0 #205761
asdf 0.16.0 #205761
Conversation
github-actions
bot
added
the
go
SMillerDev
added
the
prerelease-testing
|
@SMillerDev I've updated the PR based on your comments, it's much simpler now. asdf v0.16.0 hasn't been released yet so I'm keeping this marked as a draft. |
Stratus3D
changed the title
Stratus3D
force-pushed
the
master
branch
2 times, most recently
from
eccda73 to
21b0534
Compare
|
Hi @SMillerDev , I updated this PR with a new |
|
@Stratus3D also need to amend the commit msg as |
PR updated. |
samford
removed
the
prerelease-testing
There was a problem hiding this comment.
Thanks @Stratus3D! One minor nit and then this should be good to go.
Formula/a/asdf.rb
Outdated
| source #{opt_libexec}/asdf.fish | ||
| Restart your terminal for the settings to take effect. | ||
| EOS | ||
| system("go", "build", *std_go_args(ldflags: "-s -X main.version=#{version}"), "./cmd/asdf") |
There was a problem hiding this comment.
| system("go", "build", *std_go_args(ldflags: "-s -X main.version=#{version}"), "./cmd/asdf") | |
| system "go", "build", *std_go_args(ldflags: "-s -w -X main.version=#{version}"), "./cmd/asdf" |
There was a problem hiding this comment.
Thanks. Looks like you missed the -w from my suggestion. We usually pass -s -w to reduce binary size.
There was a problem hiding this comment.
Sorry about that. Updated the PR again to add the -w flag.
|
@p-linnane PR has been updated. |
|
@Stratus3D Please see my outstanding comment. We still need |
asdf v0.16.0 has been released. It is a complete rewrite in Go. Because of the change of language, the build and install process changes significantly. Overall the formula is more straightforward now and more in line with the numerous other Go tools distributed via Homebrew.
|
PR updated @p-linnane |
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?asdf v0.15.0 is the mot recent tag of asdf and the version currently available via Homebrew. I've been preparing to release asdf asdf v0.16.0, which is a complete rewrite in Go. Because of the change of language, the build and install process changes significantly. Overall the formula is more straightforward now and more in line with the numerous other Go tools distributed via Homebrew.
Currently
brew audit --strict asdfis failing because a version must be specified, but the new version of asdf that goes with these changes has not been tagged yet (it will be shortly).Related PRs: