Conversation
Max-282
changed the title
Creamaster
requested changes
May 3, 2021
| start_time = time.time() | ||
| request.env['payment.transaction'].form_feedback(kw, 'payzen') | ||
| _logger.info( | ||
| "Reference %s transaction was done in %s seconds" % (kw['vads_order_id'], time.time() - start_time)) |
Contributor
There was a problem hiding this comment.
mettre ca dans un finally pour gérer les erreurs, et rendre plus robuste kw['vads_order_id'] (si kw est vide ou si il ne contient pas la clé 'vads_order_id'
Warlocklogan
approved these changes
May 3, 2021
Creamaster
requested changes
May 4, 2021
Creamaster
left a comment
Creamaster
left a comment
Contributor
There was a problem hiding this comment.
penser à bump la version du module
| try: | ||
| request.env['payment.transaction'].form_feedback(kw, 'payzen') | ||
| finally: | ||
| if isinstance(kw, dict): |
Contributor
There was a problem hiding this comment.
Même si kw n'est pas un dictionnaire, il faut quand même logger le temps de réponse
Max-282
force-pushed
the
temp-10.0
branch
5 times, most recently
from
May 11, 2021 07:03
cd1171f to
ce41599
Compare
- Modification de l'url retour (utilisation de cette branche car utilisé par 3M)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #6