Skip to content

fix: keep dedupe tracking the request that replaced a cancelled one - #1753

Open
knd775 wants to merge 1 commit into
HoudiniGraphql:mainfrom
knd775:fix/dedupe-cancel-first-tracking
Open

knd775 wants to merge 1 commit into
HoudiniGraphql:mainfrom
knd775:fix/dedupe-cancel-first-tracking

Conversation

@knd775

@knd775 knd775 commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

With @dedupe(cancelFirst: true), a new request aborts the in-flight one and takes over its entry in the dedupe tracker. When the aborted request settled, its cleanup deleted that entry, so the replacement request was no longer tracked. The next request then found nothing to cancel, and the two ran side by side.

To help everyone out, please make sure your PR does the following:

  • Update the first line to point to the ticket that this PR fixes
  • Add a message that clearly describes the fix
  • If applicable, add a test that would fail without this fix
  • Make sure the unit and integration tests pass locally with pnpm run tests and cd integration && pnpm run tests
  • Includes a changeset if your fix affects the user with pnpm changeset

@changeset-bot

changeset-bot Bot commented Sep 28, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 61602f3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
houdini Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant