Add public contract config getter#308
Open
es3298 wants to merge 1 commit into
Open
Conversation
Author
|
@Naomi-Gift this PR is ready for GrantFox review for #202. It is open and mergeable, adds the public get_config snapshot with fee config, treasury, admin count, pause state, version, and public limits, plus tests and docs. Happy to provide the GrantFox/Stellar payout destination privately after acceptance/merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #202.
Summary
ContractConfigreturn type with fee config, treasury, admin count, pause state, version, and public limits.get_configgetter for frontends/indexers.Nonefor fee config/treasury before those settings are initialized, so the getter works immediately afterinitialize.get_configin the contract README and interface guide.Validation
git diff --checkAdditional validation notes:
rustfmt dongle-smartcontract/src/lib.rs dongle-smartcontract/src/types.rs dongle-smartcontract/src/tests/mod.rs dongle-smartcontract/src/tests/config.rsis currently blocked by the repository's existingdongle-smartcontract/src/utils.rsunclosed-delimiter parser error.cargo test --manifest-path dongle-smartcontract\Cargo.toml config -- --nocapturedid not complete before the local timeout in this checkout; the existing parser/compile baseline is already called out in Add batch TTL extension endpoints #305.