Skip to content

Add PWA support#20

Merged
HudsonGraeme merged 2 commits intodevfrom
feat/pwa-support
Apr 1, 2026
Merged

Add PWA support#20
HudsonGraeme merged 2 commits intodevfrom
feat/pwa-support

Conversation

@HudsonGraeme
Copy link
Copy Markdown
Owner

@HudsonGraeme HudsonGraeme commented Apr 1, 2026

Summary

  • Add web app manifest for installable app experience
  • Add PWA icons (192x192 and 512x512) generated from existing SVG
  • Add PWA meta tags including theme-color and apple-mobile-web-app support

Closes #18

Summary by CodeRabbit

  • New Features
    • Progressive Web App (PWA) support: the app is now installable and can run as a standalone application.
    • Added app manifest, icons, and theme/background colors for an improved native-like appearance when installed.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 1, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 105fd77a-ec4f-444b-b639-1d7f3c3f2ea0

📥 Commits

Reviewing files that changed from the base of the PR and between cda2dad and 680f6f2.

📒 Files selected for processing (2)
  • moci/manifest.json
  • scripts/build.js
✅ Files skipped from review due to trivial changes (1)
  • moci/manifest.json

📝 Walkthrough

Walkthrough

Added Progressive Web App support: inserted PWA-related metadata and an Apple touch icon link into moci/index.html, added a moci/manifest.json, and updated the build script to copy the manifest and moci/icons/ into dist/moci/.

Changes

Cohort / File(s) Summary
HTML head
moci/index.html
Added PWA meta and link tags: <link rel="manifest">, theme-color: #000000``, Apple mobile-web-app meta tags, and an Apple touch icon reference.
Web manifest
moci/manifest.json
New web app manifest with name, short_name, start_url, display: standalone, background_color and theme_color set to #000000, and icons for 192x192 and 512x512.
Build script / assets
scripts/build.js, moci/icons/*
Replaced copyHTML() with copyAssets() and updated build() to copy moci/manifest.json and all files from moci/icons/ into dist/moci/ alongside the existing index.html copy.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • Rebrand to MoCI #5: Modifies moci web assets and the build script; likely overlapping changes to build paths and asset handling.

Poem

🐇 I nibbled bytes and hid a sign,
A manifest and icons fine,
Head tags tucked in black design,
Now the web app hops—installed in line,
Tiny paws tap: "MoCI, you're mine!"

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Add PWA support' directly and concisely describes the main change in the pull request, which adds Progressive Web App functionality.
Linked Issues check ✅ Passed The pull request addresses all primary coding requirements from issue #18: PWA meta tags in HTML, manifest.json with required fields, and icon assets integrated into the build process.
Out of Scope Changes check ✅ Passed All changes are directly related to implementing PWA support as specified in issue #18; no unrelated modifications are present.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/pwa-support

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@moci/index.html`:
- Around line 12-16: index.html now references manifest.json and
icons/icon-192.png but the build script (scripts/build.js) only copies HTML, so
the manifest and icon assets must be copied into the dist output; update the
build pipeline to include manifest.json and the icons directory when copying
public assets (e.g., extend the copy list or modify the
copyPublicFolder/copyAssets function in scripts/build.js to copy
['index.html','manifest.json','icons/**/*'] or recursively copy the entire
public folder), ensure destination paths in dist match the URLs in index.html
and preserve relative structure, and add error handling/logging for missing
files so the build fails or warns when those assets are absent.

In `@moci/manifest.json`:
- Around line 4-16: The manifest uses absolute root paths which break installs
when the app is served from a subpath; update the "start_url" value from "/" to
a base-relative value such as "." and change icon "src" entries from
"/icons/icon-192.png" and "/icons/icon-512.png" to relative paths like
"icons/icon-192.png" and "icons/icon-512.png" so start_url and the icons resolve
correctly in subpath deployments (edit the "start_url" and the entries inside
the "icons" array in manifest.json).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 83c735d1-e341-4ff3-9433-1145326dcdc0

📥 Commits

Reviewing files that changed from the base of the PR and between f4c6720 and cda2dad.

⛔ Files ignored due to path filters (2)
  • moci/icons/icon-192.png is excluded by !**/*.png
  • moci/icons/icon-512.png is excluded by !**/*.png
📒 Files selected for processing (2)
  • moci/index.html
  • moci/manifest.json

@HudsonGraeme HudsonGraeme merged commit eabfc41 into dev Apr 1, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Progressive Web App (PWA) support

1 participant