fix(evi): mark sandbox workspaces safe for git across uid boundaries - #529
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
4 Skipped Deployments
|
|
|
Warning Review limit reached
Next review available in: 16 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe sandbox revalidation key changes from ChangesSandbox Git operations
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thank you for following the naming conventions! 🙏 |
commit: |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/evi/agent/sandbox.ts`:
- Around line 18-22: Update the safe.directory setup in bootstrap() so the
/workspace and /workspace/repo entries are written to a Git configuration shared
with onSession() and the git tools, or applied under the session identity; do
not rely solely on the template-builder user's global config. Preserve the
existing user.name and user.email configuration.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 5f7b4fa1-eb61-473f-b8cc-4597f743777c
📒 Files selected for processing (1)
apps/evi/agent/sandbox.ts
aa5ee49 to
8951908
Compare
Production GitHub turns are currently failing their checkout on every turn, and eve swallows the failure:
The sandbox template builds under a different uid than the session user, so git's ownership protection rejects
/workspaceatconfigure git remote, the checkout dies, and the turn grinds on without the repository it believes it has. This is what turned the two@evlogaimentions on #427 into hours-long silent runs with no comment posted.Bootstrap now registers
/workspaceand/workspace/repoassafe.directoryin the same global git config that already sets the bot identity, and the revalidation key bumps to v3 so existing templates rebuild.Typecheck green. No changeset: change confined to
apps/*.Summary by CodeRabbit