fix(evi): smooth the interactive run frictions - #536
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
4 Skipped Deployments
|
|
|
Thank you for following the naming conventions! 🙏 |
📝 WalkthroughWalkthroughThe agent now accepts free-form tool-approval responses, explicitly configures GitHub reviewer requests as approval-free, and announces longer-running tasks before reporting results. ChangesAgent interaction behavior
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install failed. For unrecoverable errors, disable the tool in CodeRabbit configuration. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/evi/agent/extensions/github.ts`:
- Around line 102-106: Update the authorization documentation to remove
requestReviewers from the approval-required list and explicitly document it as
not requiring approval, matching the not-applicable status returned by the
requireApproval.requestReviewers configuration.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 469c1889-b75c-47bf-9b92-f5c67d22834f
📒 Files selected for processing (3)
apps/evi/agent/channels/photon.tsapps/evi/agent/extensions/github.tsapps/evi/agent/instructions.md
| // deletePullRequestComment, createPullRequestReview, deleteLabel. | ||
| // Connect scopes are derived from `include` (createLabel → issues:write) in sdk ≥ 1.11.1. | ||
| requireApproval: { | ||
| // Reversible and harmless on every kind of run; a card here only slows the PR flow down. | ||
| requestReviewers: (): ApprovalStatus => 'not-applicable', |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Synchronize the authorization documentation.
apps/evi/docs/authorization.md Lines 109-118 still lists requestReviewers as requiring approval. This configuration now returns not-applicable. Remove requestReviewers from the approval-required list and document its approval-free status.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@apps/evi/agent/extensions/github.ts` around lines 102 - 106, Update the
authorization documentation to remove requestReviewers from the
approval-required list and explicitly document it as not requiring approval,
matching the not-applicable status returned by the
requireApproval.requestReviewers configuration.
Three frictions surfaced by the latest end-to-end run.
github__requestReviewerssat in the omitted-tools list and kept the defaultalways()approval, while the instructions require requesting a review on every non-draft PR — so every PR flow produced an approval card for a reversible, harmless action. It is nownot-applicableon every kind of run.No changeset: confined to
apps/evi. Verified:tsc, 53 unit tests,eve build.Summary by CodeRabbit