Skip to content

fix(evi): smooth the interactive run frictions - #536

Merged
HugoRCD merged 1 commit into
mainfrom
fix/evi-run-frictions
Aug 9, 2026
Merged

fix(evi): smooth the interactive run frictions#536
HugoRCD merged 1 commit into
mainfrom
fix/evi-run-frictions

Conversation

@HugoRCD

@HugoRCD HugoRCD commented Aug 9, 2026

Copy link
Copy Markdown
Owner

Three frictions surfaced by the latest end-to-end run.

  • github__requestReviewers sat in the omitted-tools list and kept the default always() approval, while the instructions require requesting a review on every non-draft PR — so every PR flow produced an approval card for a reversible, harmless action. It is now not-applicable on every kind of run.
  • Long silent stretches: iMessage has no typing indicator, so the minutes between an answer and the finished PR read as a hang. Instructions now require a one-line announcement before starting work that will take more than a minute or two on a chat channel.
  • Input-request prompts listed only the option-id replies; free-form answers were always accepted but nothing said so. The photon prompt now ends with "Or answer in your own words."

No changeset: confined to apps/evi. Verified: tsc, 53 unit tests, eve build.

Summary by CodeRabbit

  • Improvements
    • Tool-approval prompts now let you respond in your own words when options are provided.
    • Longer-running chat tasks now include an announcement before work begins, followed by a result update.
    • Review requests can be sent without an additional approval prompt.

@vercel

vercel Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
evi Ready Ready Preview Aug 9, 2026 4:46pm
4 Skipped Deployments
Project Deployment Actions Updated (UTC)
evlog-docs Skipped Skipped v0 Aug 9, 2026 4:46pm
evlog-render-lab Skipped Skipped Aug 9, 2026 4:46pm
evlog-telemetry Skipped Skipped Aug 9, 2026 4:46pm
just-use-evlog Skipped Skipped Aug 9, 2026 4:46pm

Request Review

@vercel
vercel Bot temporarily deployed to Preview – evlog-render-lab August 9, 2026 16:44 Inactive
@vercel
vercel Bot temporarily deployed to Preview – evlog-telemetry August 9, 2026 16:44 Inactive
@vercel
vercel Bot temporarily deployed to Preview – evlog-docs August 9, 2026 16:44 Inactive
@vercel
vercel Bot temporarily deployed to Preview – just-use-evlog August 9, 2026 16:44 Inactive
@changeset-bot

changeset-bot Bot commented Aug 9, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: f46368f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions Bot added the bug Something isn't working label Aug 9, 2026
@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Thank you for following the naming conventions! 🙏

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The agent now accepts free-form tool-approval responses, explicitly configures GitHub reviewer requests as approval-free, and announces longer-running tasks before reporting results.

Changes

Agent interaction behavior

Layer / File(s) Summary
Approval prompt and reviewer configuration
apps/evi/agent/channels/photon.ts, apps/evi/agent/extensions/github.ts
Photon prompts allow answers in the user’s own words. requestReviewers uses a not-applicable approval status and is removed from the omitted write-tool list.
Long-running task announcements
apps/evi/agent/instructions.md
Instructions require a brief start announcement for tasks expected to take more than a minute or two, followed by the result.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies an Evi fix for interactive run friction and uses the repository's conventional commit format.
Description check ✅ Passed The description explains all three changes, their rationale, scope, and verification results, although it omits the template headings and checklist.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/evi-run-frictions

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install failed. For unrecoverable errors, disable the tool in CodeRabbit configuration.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Aug 9, 2026

Copy link
Copy Markdown
npm i https://pkg.pr.new/@evlog/cli@536
npm i https://pkg.pr.new/evlog@536
npm i https://pkg.pr.new/@evlog/nuxthub@536
npm i https://pkg.pr.new/@evlog/telemetry@536

commit: f46368f

@HugoRCD HugoRCD self-assigned this Aug 9, 2026
@HugoRCD
HugoRCD merged commit db00bac into main Aug 9, 2026
21 of 22 checks passed
@HugoRCD
HugoRCD deleted the fix/evi-run-frictions branch August 9, 2026 16:46

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@apps/evi/agent/extensions/github.ts`:
- Around line 102-106: Update the authorization documentation to remove
requestReviewers from the approval-required list and explicitly document it as
not requiring approval, matching the not-applicable status returned by the
requireApproval.requestReviewers configuration.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 469c1889-b75c-47bf-9b92-f5c67d22834f

📥 Commits

Reviewing files that changed from the base of the PR and between 9bb702c and f46368f.

📒 Files selected for processing (3)
  • apps/evi/agent/channels/photon.ts
  • apps/evi/agent/extensions/github.ts
  • apps/evi/agent/instructions.md

Comment on lines +102 to +106
// deletePullRequestComment, createPullRequestReview, deleteLabel.
// Connect scopes are derived from `include` (createLabel → issues:write) in sdk ≥ 1.11.1.
requireApproval: {
// Reversible and harmless on every kind of run; a card here only slows the PR flow down.
requestReviewers: (): ApprovalStatus => 'not-applicable',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

Synchronize the authorization documentation.

apps/evi/docs/authorization.md Lines 109-118 still lists requestReviewers as requiring approval. This configuration now returns not-applicable. Remove requestReviewers from the approval-required list and document its approval-free status.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@apps/evi/agent/extensions/github.ts` around lines 102 - 106, Update the
authorization documentation to remove requestReviewers from the
approval-required list and explicitly document it as not requiring approval,
matching the not-applicable status returned by the
requireApproval.requestReviewers configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant