fix(evi): trust local eve dev sessions as the maintainer - #541
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
4 Skipped Deployments
|
|
|
Warning Review limit reached
Next review available in: 27 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthrough
ChangesEnvironment-Based Trust
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Thank you for following the naming conventions! 🙏 |
commit: |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/evi/agent/lib/trust.test.ts`:
- Around line 16-22: Clear EVE_RUN_MODE in the trust loaders before importing
modules: update loadTrust() in apps/evi/agent/lib/trust.test.ts (lines 16-22)
and load() in apps/evi/agent/lib/github/label-approval.test.ts (lines 16-17) to
reset it alongside VERCEL_ENV, ensuring eval mode cannot leak into subsequent
cases.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: cf10b8e6-1a0d-4b28-aeb2-a116ad80510f
📒 Files selected for processing (3)
apps/evi/agent/lib/github/label-approval.test.tsapps/evi/agent/lib/trust.test.tsapps/evi/agent/lib/trust.ts
Asking the local
eve devREPL anything admin-gated (Vercel MCP, the new Linear MCP, ai-gateway, captures, push) failed with "This tool is not available in the current session": the REPL caller is neither a maintainer principal nor the schedule app principal, so every gate refused it — which made the admin surface untestable from the machine it runs on.isMaintainernow returns true whenenvironment()resolves tolocal: aneve devsession runs on the maintainer's own machine. Deployments resolve to theirVERCEL_ENVand eval runs toeval, so nothing changes there — covered by a dedicated test, and the existing trust/label tests now pinVERCEL_ENV=productionexplicitly so they keep modeling deployed behavior.No changeset: confined to
apps/evi. Verified:tsc, 54 unit tests,eve build.Summary by CodeRabbit