fix(docs): remove html comments from animation templates - #566
Merged
Conversation
|
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
3 Skipped Deployments
|
Contributor
|
Thank you for following the naming conventions! 🙏 |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes ~35 narrative HTML comments from
<template>blocks across the docs animation components, and nothing else. The eslint control directives (<!-- eslint-disable/enable -->) are left intact.Why
Root
AGENTS.md(Conventions) states: "No HTML comments (<!-- -->) in Vue templates."apps/docs/AGENTS.mddoes not waive it for the MDC animation components. These comments were navigation markers that slipped in against the rule.Checks
pnpm turbo run lint --filter=evlog-docs: pass.pnpm turbo run typecheck --filter=evlog-docs: pass.apps/*only.Self-review finding: rule stated in
AGENTS.mdvs the code (part B, guides the code stopped obeying).