fix(reefine): recover E2B disconnects and surface failed proposals - #565
Merged
Merged
Conversation
|
Merge Oncall: @BobbyZhouZijian The merge oncall will route reviews and keep this pull request moving toward a clear decision. |
BobbyZhouZijian
marked this pull request as ready for review
September 21, 2026 11:31
BobbyZhouZijian
enabled auto-merge (squash)
September 21, 2026 11:31
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
An E2B command stream disconnect currently aborts an already running Reefine proposer, while a failed tunnel transfer can make an incomplete model response look complete. These failures then appear as No changes. Preserve the running command across transient disconnects and show an explicit failure when recovery is exhausted.
Related implementation: #538 and #556. Searched existing E2B issues and PRs; no open duplicate found.
Changes
Compatibility and operational impact
No persisted record migration is needed; existing failure records receive the corrected display. The progress API can now report
state: failedfor a skipped step with a recorded error. The private tunnel protocol is updated on both ends together. E2B remains optional with its existing>=2.46requirement; itsconnectrpcdependency is now declared explicitly. Restart the service to load the fix and resubmit failed requests.Verification
pre-commit run --all-filesandpython -m mypypassed (321 source files).python -m pytest tests/attempted: collection blocked by missingtorch,ray, andslime(13 collection errors, 12 skipped).AI assistance
OpenAI Codex implemented the fix, regression tests, documentation, and this PR description. The human contributor remains responsible for reviewing and understanding the change.
Checklist
README.i18n.yaml, or do not affect README content.Review and merge
Draft pending review and CI in the supported training environment. Follow the repository's Merge Oncall workflow.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.