Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add region:visibility-all shortcut (ctrl+h) #6212

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

LouisJULIEN
Copy link

@LouisJULIEN LouisJULIEN commented Aug 15, 2024

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

(link to issue, supportive screenshots etc.)
No shortcut existed to hide all regions. It had to be done through a click tot he dedicated button on the sidebar

What does this fix?

(if this is a bug fix)

What is the new behavior?

(if this is a breaking or feature change)
by default, ctrl+h now hide all regions if one is visible. If none is visible, it show all regions.

What is the current behavior?

(if this is a breaking or feature change)
ctrl + h has no behavior on label studio.

What libraries were added/updated?

(list all with version changes)
None

Does this change affect performance?

(if so describe the impacts positive or negative)
No

Does this change affect security?

(if so describe the impacts positive or negative)
No

What alternative approaches were there?

(briefly list any if applicable)
Click on the sidebar button

What feature flags were used to cover this change?

(briefly list any if applicable)
None

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit
    Does manual testing counts for a shortcut (I kind of hate myself for asking)?

Which logical domain(s) does this change affect?

(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)

Copy link

netlify bot commented Aug 15, 2024

👷 Deploy request for label-studio-docs-new-theme pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 39efce4

Copy link

netlify bot commented Aug 15, 2024

👷 Deploy request for heartex-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 39efce4

@github-actions github-actions bot added the feat label Aug 15, 2024
@LouisJULIEN LouisJULIEN force-pushed the hide-all-shorcut-2 branch 2 times, most recently from 3b4406f to 2d2ef63 Compare August 19, 2024 13:20
@LouisJULIEN
Copy link
Author

I reverted my changes made to web/dist, no idea if that's what's expected

@LouisJULIEN
Copy link
Author

Hello! Would it be possible to review this PR? I tried to make it as small and as little as possible to ease review. Thanks!

@LouisJULIEN
Copy link
Author

Up! @hlomzik maybe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant