feat: LEAP-1439: Display link in existing comment and allow linking #6404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce `CommentMode` and `RelationMode` to handle linking annotations with regions. Also, refactor parts of the code to unify the method of linking actions under `LinkingModes` and replace deprecated `relationMode` checks.
Moved the `comment` and `firstRegion` variables to volatile state within the MobX-state-tree models for `CommentMode` and `RelationMode`. This change provides access to payload information of modes in case we need it.
Co-authored-by: hlomzik <[email protected]>
Co-authored-by: hlomzik <[email protected]>
Co-authored-by: hlomzik <[email protected]>
Updated all instances of `Constants.RELATION_MODE_CURSOR` to `Constants.LINKING_MODE_CURSOR` across various files. This ensures consistency in naming and improves code readability for linking mode features.
Refactored comments feature to support per-field comments through feature flags, added linking functionality between comments and regions, and updated UI with new icons and styles.
Reorganize the comment form components by separating old and new versions. Adjust CSS class names to avoid conflicts and import paths for clarity.
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
web/libs/editor/src/components/Comments/Comment/CommentItem.tsx
Outdated
Show resolved
Hide resolved
Replace `displayRegionLabel` with `RegionLabel` component in OutlinerTree and LinkState components.
|
/git merge fb-leap-1440/link-new-comment
|
Co-authored-by: bmartel <[email protected]>
Co-authored-by: bmartel <[email protected]>
Co-authored-by: bmartel <[email protected]>
yyassi-heartex
approved these changes
Sep 23, 2024
Refactor the feature flag checks by introducing the `isPerFieldComments` variable.
|
/git merge develop
|
✅ Deploy Preview for label-studio-docs-new-theme ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for heartex-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Gondragos
changed the title
hlomzik
reviewed
Sep 25, 2024
hlomzik
reviewed
Sep 25, 2024
Improve the comment update process by incorporating `snakeizeKeys` for `props`. Properly handle update error state by setting `isUpdating` to false when errors occur. Simplify `regionRef` processing by removing unnecessary `snakeizeKeys` calls on upper level.
|
/git merge develop
|
Updated CommentForm to use commentInProgress instead of currentComment for improved clarity. Also, included annotationStore in CommentBase creation to ensure consistent data access.
…abs/label-studio into fb-leap-1439/link-comment
hlomzik
reviewed
Sep 25, 2024
web/libs/editor/src/components/Comments/Comment/CommentsList.tsx
Outdated
Show resolved
Hide resolved
web/libs/editor/src/components/Comments/Comment/CommentItem.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: hlomzik <[email protected]>
hlomzik
approved these changes
Sep 25, 2024
…abs/label-studio into fb-leap-1439/link-comment
|
/git merge develop
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides an ability to link an existing comment to a region and display linked region.
Other changes:
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change madeex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errorsChange has impacts in these area(s)
Describe the reason for change
It's a part of implementing linking comment to region functionality.
What feature flags were used to cover this change?
fflag_feat_all_leap_1430_per_field_comments_100924_shortDoes this PR introduce a breaking change?
What level of testing was included in the change?
(check all that apply)
Which logical domain(s) does this change affect?
Comments