Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: LEAP-1467: Adapt Textarea result container to new style #6413

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

feat: LEAP-1467: Adapt Textarea result container to new style #6413

wants to merge 2 commits into from

Conversation

ricardoantoniocm
Copy link

Description

Adapts the result containers of the TextArea tag to match the new look and feel

Testing

  1. Create a project and set up a labeling configuration with the TextArea tag with the parameters editable="true" and transcription="false"
  2. Import any text data
  3. Start labeling
  4. Enter any text on the TextArea box and press Enter or click on the Add button
  5. Notice the results container matches the new look and feel

Screenshots

Before:
image

After:
Label_Studio

@ricardoantoniocm
* Improves the look and feel of the Textbox results container to matc…
0b4f7ef 
…h the current brand style.

* Moves the edit button outside the container.
* Ensure result containers expand the full width so that buttons are aligned on the right.
* Adds tooltips to controls.
@netlify Netlify
Copy link

netlify bot commented Sep 20, 2024 •
edited
Loading

✅ Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 3ccf063
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/66ed78abe255760008ac7fa4

@netlify Netlify
Copy link

netlify bot commented Sep 20, 2024 •
edited
Loading

✅ Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 3ccf063
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/66ed78ab7e684d0008c2e97c

@github-actions github-actions bot added the feat label Sep 20, 2024
yyassi-heartex
yyassi-heartex approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@yyassi-heartex yyassi-heartex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! one thing to call out for the Tokenization initiative is we have 4px, 8px, 12px and 24px reused through out the application for border radius, gap and spacing related styles so it would be good to be changed to a css variable as part of that initiative - what do you think?

bmartel
bmartel approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@bmartel bmartel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, I applied the suggestion for spacing for you so we can merge when ready 💪

@ricardoantoniocm
Copy link
Author

looks good! one thing to call out for the Tokenization initiative is we have 4px, 8px, 12px and 24px reused through out the application for border radius, gap and spacing related styles so it would be good to be changed to a css variable as part of that initiative - what do you think?

Thank you for pointing this out. I'll introduce these variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hlomzik hlomzik hlomzik approved these changes

@bmartel bmartel bmartel approved these changes

@yyassi-heartex yyassi-heartex yyassi-heartex approved these changes

Assignees
No one assigned
Labels
feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ricardoantoniocm @hlomzik @bmartel @yyassi-heartex