fix: ROOT-223: Optimize "Delete predictions" DM action #8700

matt-bernstein · 2025-10-23T21:10:41Z

Shuffle around DB queries for this codepath

netlify · 2025-10-23T21:10:48Z

✅ Deploy Preview for heartex-docs ready!

Name	Link
🔨 Latest commit	`e64d9c2`
🔍 Latest deploy log	https://app.netlify.com/projects/heartex-docs/deploys/6904b90590612700084b7ec3
😎 Deploy Preview	https://deploy-preview-8700--heartex-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify · 2025-10-23T21:10:48Z

✅ Deploy Preview for label-studio-storybook ready!

Name	Link
🔨 Latest commit	`e64d9c2`
🔍 Latest deploy log	https://app.netlify.com/projects/label-studio-storybook/deploys/6904b905967a4b000863ef3c
😎 Deploy Preview	https://deploy-preview-8700--label-studio-storybook.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify · 2025-10-23T21:10:49Z

✅ Deploy Preview for label-studio-playground ready!

Name	Link
🔨 Latest commit	`e64d9c2`
🔍 Latest deploy log	https://app.netlify.com/projects/label-studio-playground/deploys/6904b905444c7100083efb82
😎 Deploy Preview	https://deploy-preview-8700--label-studio-playground.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify · 2025-10-23T21:11:36Z

✅ Deploy Preview for label-studio-docs-new-theme ready!

Name	Link
🔨 Latest commit	`e64d9c2`
🔍 Latest deploy log	https://app.netlify.com/projects/label-studio-docs-new-theme/deploys/6904b905ad693200088ef009
😎 Deploy Preview	https://deploy-preview-8700--label-studio-docs-new-theme.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

codecov · 2025-10-24T12:30:53Z

Codecov Report

❌ Patch coverage is 50.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.78%. Comparing base (c4bf052) to head (e64d9c2).
⚠️ Report is 2 commits behind head on develop.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
label_studio/data_manager/actions/basic.py	25.00%	3 Missing ⚠️
label_studio/data_manager/api.py	62.50%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##           develop    #8700       +/-   ##
============================================
+ Coverage    67.04%   79.78%   +12.74%     
============================================
  Files          790      239      -551     
  Lines        60686    21691    -38995     
  Branches     10316        0    -10316     
============================================
- Hits         40684    17306    -23378     
+ Misses       19999     4385    -15614     
+ Partials         3        0        -3

Flag	Coverage Δ
lsf-e2e	`?`
lsf-integration	`?`
lsf-unit	`?`
pytests	`79.78% <50.00%> (-0.05%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

matt-bernstein · 2025-10-27T20:45:14Z

/fm sync

Workflow run

matt-bernstein · 2025-10-27T20:45:30Z

/git merge develop

Workflow run
Successfully merged: create mode 100644 web/libs/ui/src/assets/icons/clipboard-check.svg

Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/18855423378

Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/18855416853

matt-bernstein · 2025-10-28T13:02:40Z

/git merge develop

Workflow run
Successfully merged: create mode 100644 web/libs/datamanager/src/hooks/useActions.ts

Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/18875658895

matt-bernstein · 2025-10-29T14:20:34Z

/git merge develop

Workflow run
Successfully merged: create mode 100644 label_studio/core/static/samples/opossum-cuteness.pdf

Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/18911129936

jombooth · 2025-10-29T21:16:27Z

label_studio/data_manager/api.py

        project = generics.get_object_or_404(Project, pk=pk)
        self.check_object_permissions(request, project)

-        queryset = get_prepared_queryset(request, project)


why not keep this codepath unchanged if the FF is off?

The ff-off path is identical to the body of get_prepared_queryset, I figured the effect of the change is more readable this way

label-studio/label_studio/data_manager/functions.py

Lines 329 to 332 in b52eb9d

def get_prepared_queryset(request, project):

prepare_params = get_prepare_params(request, project)

queryset = Task.prepared.only_filtered(prepare_params=prepare_params)

return queryset

It's only used in one other place, could be worth removing this function entirely if we end up touching the other callsite

matt-bernstein · 2025-10-30T15:58:53Z

/git merge develop

Workflow run
Successfully merged: create mode 100644 web/libs/ui/src/assets/icons/ui.svg

Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/18946939149

jombooth

LGTM, cool idea of cutting ordering from delete queries 👍

matt-bernstein · 2025-10-31T13:25:47Z

/git merge develop

Workflow run
Successfully merged: create mode 100644 docs/source/images/tutorials/tutorials-hugging-face-ls-sdk.png

Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/18973961259

matt-bernstein added 3 commits October 23, 2025 17:06

feat: ROOT-223: Optimize "Delete predictions" DM action

a2a420c

efficiently find tasks with predictions before applying action

7718852

skip ordering for tasks queryset for actions

bfda176

matt-bernstein requested a review from a team as a code owner October 23, 2025 21:10

github-actions bot added the feat label Oct 23, 2025

matt-bernstein added 4 commits October 23, 2025 17:26

bugfix

c6f8cb7

bugfix

94fd0ef

more readable

42aad1d

order remove_duplicaes

d0f894a

matt-bernstein added 2 commits October 24, 2025 08:31

Merge remote-tracking branch 'origin/develop' into fb-ROOT-223

c5914d0

readability

d1222b3

matt-bernstein changed the title ~~feat: ROOT-223: Optimize "Delete predictions" DM action~~ fix: ROOT-223: Optimize "Delete predictions" DM action Oct 24, 2025

github-actions bot added the fix label Oct 24, 2025

ff

5d45374

matt-bernstein requested a review from jombooth October 24, 2025 17:40

matt-bernstein added 2 commits October 24, 2025 15:22

remove redundant order_by

51d2c6e

Merge remote-tracking branch 'origin/develop' into fb-ROOT-223

589039b

matt-bernstein added 2 commits October 27, 2025 20:46

Merge branch 'develop' into 'fb-ROOT-223'

a91fa26

Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/18855423378

Sync Follow Merge dependencies

01fa7fa

Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/18855416853

robot-ci-heartex assigned matt-bernstein Oct 27, 2025

robot-ci-heartex added the FM Stale label Oct 27, 2025

Merge branch 'develop' into 'fb-ROOT-223'

e2cb622

Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/18875658895

Merge branch 'develop' into 'fb-ROOT-223'

63cc316

Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/18911129936

jombooth reviewed Oct 29, 2025

View reviewed changes

Merge branch 'develop' into 'fb-ROOT-223'

034b6b3

Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/18946939149

jombooth approved these changes Oct 30, 2025

View reviewed changes

Merge branch 'develop' into 'fb-ROOT-223'

e64d9c2

Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/18973961259

robot-ci-heartex merged commit deed6b9 into develop Oct 31, 2025
52 of 53 checks passed

robot-ci-heartex deleted the fb-ROOT-223 branch October 31, 2025 17:50

	def get_prepared_queryset(request, project):
	prepare_params = get_prepare_params(request, project)
	queryset = Task.prepared.only_filtered(prepare_params=prepare_params)
	return queryset

fix: ROOT-223: Optimize "Delete predictions" DM action #8700

fix: ROOT-223: Optimize "Delete predictions" DM action #8700

Conversation

matt-bernstein commented Oct 23, 2025

Uh oh!

netlify bot commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for heartex-docs ready!

Uh oh!

netlify bot commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for label-studio-storybook ready!

Uh oh!

netlify bot commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for label-studio-playground ready!

Uh oh!

netlify bot commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for label-studio-docs-new-theme ready!

Uh oh!

codecov bot commented Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

matt-bernstein commented Oct 27, 2025 • edited by robot-ci-heartex Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matt-bernstein commented Oct 27, 2025 • edited by robot-ci-heartex Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matt-bernstein commented Oct 28, 2025 • edited by robot-ci-heartex Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matt-bernstein commented Oct 29, 2025 • edited by robot-ci-heartex Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jombooth Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

matt-bernstein Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

matt-bernstein Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

matt-bernstein commented Oct 30, 2025 • edited by robot-ci-heartex Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jombooth left a comment

Choose a reason for hiding this comment

Uh oh!

matt-bernstein commented Oct 31, 2025 • edited by robot-ci-heartex Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

netlify bot commented Oct 23, 2025 •

edited

Loading

netlify bot commented Oct 23, 2025 •

edited

Loading

netlify bot commented Oct 23, 2025 •

edited

Loading

netlify bot commented Oct 23, 2025 •

edited

Loading

codecov bot commented Oct 24, 2025 •

edited

Loading

matt-bernstein commented Oct 27, 2025 •

edited by robot-ci-heartex

Loading

matt-bernstein commented Oct 27, 2025 •

edited by robot-ci-heartex

Loading

matt-bernstein commented Oct 28, 2025 •

edited by robot-ci-heartex

Loading

matt-bernstein commented Oct 29, 2025 •

edited by robot-ci-heartex

Loading

matt-bernstein Oct 30, 2025 •

edited

Loading

matt-bernstein commented Oct 30, 2025 •

edited by robot-ci-heartex

Loading

matt-bernstein commented Oct 31, 2025 •

edited by robot-ci-heartex

Loading