Improve vertical window handling

Hydr8gon · Sep 13, 2024 · e2c1677 · e2c1677
1 parent c0816ca
commit e2c1677
Show file tree

Hide file tree

Showing 4 changed files with 106 additions and 115 deletions.
diff --git a/.github/workflows/autobuild.yml b/.github/workflows/autobuild.yml
@@ -27,7 +27,7 @@ jobs:
       shell: msys2 {0}
       working-directory: ${{ github.workspace }}
     - name: Upload
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v4
       with:
         name: noods-windows
         path: noods.exe
@@ -45,7 +45,7 @@ jobs:
         make -j$(sysctl -n hw.logicalcpu)
         ./mac-bundle.sh --dmg
     - name: Upload
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v4
       with:
         name: noods-mac
         path: NooDS.dmg
@@ -67,7 +67,7 @@ jobs:
         git config --global protocol.file.allow always
         make flatpak
     - name: Upload
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v4
       with:
         name: noods-linux
         path: noods.flatpak
@@ -87,7 +87,7 @@ jobs:
       env:
         KEYSTORE_PASS: ${{ secrets.KEYSTORE_PASS }}
     - name: Upload
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v4
       with:
         name: noods-android
         path: noods.apk
@@ -102,7 +102,7 @@ jobs:
     - name: Compile
       run: make switch -j$(nproc)
     - name: Upload
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v4
       with:
         name: noods-switch
         path: noods.nro
@@ -117,7 +117,7 @@ jobs:
     - name: Compile
       run: make wiiu -j$(nproc)
     - name: Upload
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v4
       with:
         name: noods-wiiu
         path: noods.wuhb
@@ -132,7 +132,7 @@ jobs:
     - name: Compile
       run: make vita -j$(nproc)
     - name: Upload
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v4
       with:
         name: noods-vita
         path: noods.vpk
@@ -150,7 +150,7 @@ jobs:
       env:
         GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
     - name: Get artifacts
-      uses: actions/download-artifact@v2
+      uses: actions/download-artifact@v4
     - name: Package artifacts
       run: for i in ./*; do zip -r -j ${i}.zip $i; done
     - name: Create new release

diff --git a/src/gpu.cpp b/src/gpu.cpp
@@ -344,6 +344,9 @@ void Gpu::gbaScanline308()
             break;
     }
 
+    // Update window flags for the next scanline
+    core->gpu2D[0].updateWindows(vCount);
+
     // Signal that the next scanline should start drawing
     if (vCount < 160 && thread)
         drawing.store(1);
@@ -631,6 +634,10 @@ void Gpu::scanline355()
             break;
     }
 
+    // Update window flags for the next scanline
+    core->gpu2D[0].updateWindows(vCount);
+    core->gpu2D[1].updateWindows(vCount);
+
     // Signal that the next scanline should start drawing
     if (vCount < 192 && thread)
         drawing.store(1);