Limit IoT MCP server to registry tools - #448
Merged
Merged
Conversation
Signed-off-by: Shuxin Lin <linshuhsin@gmail.com>
Signed-off-by: Shuxin Lin <linshuhsin@gmail.com>
Signed-off-by: Shuxin Lin <linshuhsin@gmail.com>
Signed-off-by: Shuxin Lin <linshuhsin@gmail.com>
Signed-off-by: Shuxin Lin <linshuhsin@gmail.com>
Signed-off-by: Shuxin Lin <linshuhsin@gmail.com>
Signed-off-by: Shuxin Lin <linshuhsin@gmail.com>
DhavalRepo18
approved these changes
Jul 14, 2026
DhavalRepo18
left a comment
Collaborator
There was a problem hiding this comment.
Once all the Tools are in place in the IoT, I will make a clean review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sites,asset_ids, andassetssites()using the registry-backed site discovery pattern from the pinned upstream IoT serverasset_ids()return only sortedassetnumvalues for a siteassets()return compact registry metadata, with optionalassettypefilteringArgsand successful-resultReturnssections_id,doctype,iot_asset_id, andwo_assetnumfromsrc/couchdb/scenarios_data/shared/iot/asset_profile_sample.jsonTool Surface
sites()->{"sites": [...]}asset_ids(site_name)-> bare asset id list for the siteassets(site_name, assettype?)-> asset metadata rows:asset_id,description,assettype,vintage,n_sensorsTests
.venv/bin/python -m pytest src/servers/iot/tests src/mcphub/tests(13 passed, 5 skipped; registry integrations skipped locally)jq empty src/couchdb/scenarios_data/shared/iot/asset_profile_sample.json.venv/bin/python -m py_compile src/servers/iot/main.py src/servers/iot/tests/test_tools.py src/mcphub/workflows.py src/mcphub/tests/test_workflows.py['asset_ids', 'assets', 'sites']Args, and successful-resultReturnssections for the IoT tools