Skip to content

Conversation

@SaschaSchwarze0
Copy link
Member

The trusted profile sample is nested because it contains one directory per language. The build file in those directories was not getting picked up.

@SaschaSchwarze0 SaschaSchwarze0 force-pushed the sascha-build-nested-directories branch from 423b941 to 3f0bdd1 Compare March 27, 2025 12:22
@SaschaSchwarze0 SaschaSchwarze0 force-pushed the sascha-build-nested-directories branch from 3f0bdd1 to df24eb2 Compare March 27, 2025 14:38
Copy link
Collaborator

@reggeenr reggeenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

--build-source https://github.com/IBM/CodeEngine \
--build-context-dir trusted-profiles/${PROGRAMMING_LANGUAGE} \
--trusted-profiles-enabled true \
--trusted-profiles-enabled=true \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is interesting. Is it by intention?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it has to be there. Boolean flags require the = sign in the Go CLI libraries. Without it, it does not work.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aaah that I didn't know! Thanks for sharing

@SaschaSchwarze0 SaschaSchwarze0 merged commit f12f32a into main Mar 27, 2025
2 checks passed
@SaschaSchwarze0 SaschaSchwarze0 deleted the sascha-build-nested-directories branch March 27, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants