Skip to content

multiple changes to make script more flexible #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jeremiaswerner merged 2 commits into from
Aug 12, 2025
Merged

multiple changes to make script more flexible #220

jeremiaswerner merged 2 commits into from
Aug 12, 2025

Conversation

@jeremiaswerner
Copy link
Collaborator

@jeremiaswerner jeremiaswerner commented Aug 11, 2025 •
edited
Loading

  1. allow REGION to be configured by user
  2. allow NAME_PREFIX to be configured by user
  3. make sure that region and resource group are properly targeted
  4. add creation of secret 'codeengine-fleet-defaults' for walk milestone
  5. add creation of persistent data store for walk milestone
  6. add lifecycle policies to expire result object after 1 day in COS

@jeremiaswerner jeremiaswerner changed the title create codeengine-fleet-defaults secret and persistent data store. fi.. multiple changes to make script more flexible Aug 11, 2025
groezing
groezing approved these changes Aug 12, 2025
View reviewed changes
Copy link
Member

@groezing groezing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@jeremiaswerner jeremiaswerner merged commit 1a89e30 into IBM:main Aug 12, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevenwhitehead stevenwhitehead stevenwhitehead approved these changes

@groezing groezing groezing approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jeremiaswerner @stevenwhitehead @groezing