-
Notifications
You must be signed in to change notification settings - Fork 151
intial version to support walk milestone and beta version #222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
reggeenr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really cool!
Only found some minor discrepancies between echo output and actual applied values.
Once this is in for a few days, we should consider to put a info text on top of the experimental readme stating that there is a beta version available. Alternatively, we could apply a symlink pointing the user to the beta readme right-away.
Co-authored-by: Enrico Regge <[email protected]>
Co-authored-by: Enrico Regge <[email protected]>
Co-authored-by: Enrico Regge <[email protected]>
Co-authored-by: Enrico Regge <[email protected]>
Co-authored-by: Steven Whitehead <[email protected]>
Co-authored-by: Enrico Regge <[email protected]>
Co-authored-by: Enrico Regge <[email protected]>
Co-authored-by: Enrico Regge <[email protected]>
Co-authored-by: Enrico Regge <[email protected]>
|
@reggeenr @stevenwhitehead thank you for the review. I incorporated the feedback. I also changed the rclone environment to be more dynamic. It now generates a rclone config per resource group. The upload and download script lookup the targeted resource group, the buckets and use the corresponding rclone environment. This allows to setup and switch between multiple resource groups. Pls have a final look and feel free to merge... |
reggeenr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
remove experimental (crawl) items
add beta (walk) items:
betacommand groupWhat's missing is the inferencing and simulation tutorial... I've removed them for now and we can add them back step by step.