Skip to content

fix support for fleets by checking for fleets first #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jeremiaswerner merged 1 commit into from
Sep 5, 2025
Merged

fix support for fleets by checking for fleets first #228

jeremiaswerner merged 1 commit into from
Sep 5, 2025

Conversation

@jeremiaswerner
Copy link
Collaborator

@jeremiaswerner jeremiaswerner commented Sep 5, 2025 •
edited
Loading

Problem:

  • Fleet instances contain the JOB_INDEX variable as well
  • Therefore the instance will run as a daemon job which is the default JOB_MODE
  • Fleet in principal support daemon mode but the current default should be task mode

Fix:

  • Check for fleets first and run in fleet mode which terminates the task immediately

reggeenr
reggeenr approved these changes Sep 5, 2025
View reviewed changes
Copy link
Collaborator

@reggeenr reggeenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeremiaswerner jeremiaswerner merged commit 8f71f95 into IBM:main Sep 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reggeenr reggeenr reggeenr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jeremiaswerner @reggeenr