Check that integer representation of message is smaller than modulus#1252
Merged
Conversation
KostasTsiounis
force-pushed
the
rsa_check
branch
from
c813d0d to
eb99287
Compare
KostasTsiounis
requested review from
JinhangZhang,
jasonkatonica,
johnpeck-us-ibm and
taoliult
johnpeck-us-ibm
requested changes
Mar 9, 2026
jasonkatonica
requested changes
Mar 18, 2026
KostasTsiounis
force-pushed
the
rsa_check
branch
from
14fcde8 to
788f9e3
Compare
johnpeck-us-ibm
approved these changes
Apr 6, 2026
In RSA cipher operations, the message is converted into an integer that needs to be smaller than the public key's modulus. A check is added to fail early with the proper message, instead of failing during the actual operation with a not so helpful message. Additional tests to verify that behaviour are introduced as well. Signed-off-by: Kostas Tsiounis <kostas.tsiounis@ibm.com>
This was referenced Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In RSA cipher operations, the message is converted into an integer that needs to be smaller than the public key's modulus.
A check is added to fail early with the proper message, instead of failing during the actual operation with a not so helpful message.
An additional test to verify that behaviour is introduced as well.
Signed-off-by: Kostas Tsiounis kostas.tsiounis@ibm.com