Skip to content

Extract library-specific elements to separate files#1442

Merged
jasonkatonica merged 2 commits into
IBM:java11from
KostasTsiounis:extract_common_j11
May 13, 2026
Merged

Extract library-specific elements to separate files#1442
jasonkatonica merged 2 commits into
IBM:java11from
KostasTsiounis:extract_common_j11

Conversation

@KostasTsiounis

Copy link
Copy Markdown
Member

For each of the platform-specific makefiles, the rules and variables that are applicable to all potential native libraries are extracted to common makefiles.

The original makefiles only maintain the library-specific elements and include the equivalent common makefiles for the rest of them.

Back-ported from: #1419

Signed-off-by: Kostas Tsiounis kostas.tsiounis@ibm.com

For each of the platform-specific makefiles, the rules and variables
that are applicable to all potential native libraries are extracted
to common makefiles.

The original makefiles only maintain the library-specific elements
and include the equivalent common makefiles for the rest of them.

Signed-off-by: Kostas Tsiounis <kostas.tsiounis@ibm.com>
@KostasTsiounis

Copy link
Copy Markdown
Member Author

The difference in lines between this and the 25+ versions is due to the following reasons:

  • AIX has been updated to use the ibm-clang_r compiler in later versions, which requires different flags => I've maintained the appropriate compiler per version
  • z/OS has also been updated to use the ibm-clang64 compiler in later versions, which requires different flags => I've synced all versions given that they probably won't be directly used
  • There was a discrepancy in the displaycompiler rule in the linux makefile => it has been synced up to main in all versions

Signed-off-by: Kostas Tsiounis <kostas.tsiounis@ibm.com>

@taoliult taoliult left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasonkatonica jasonkatonica left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasonkatonica jasonkatonica merged commit c858985 into IBM:java11 May 13, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants