Improve buffer handling during error handling#1484
Merged
jasonkatonica merged 1 commit intoMay 26, 2026
Conversation
jasonkatonica
changed the title
- Replace unsafe vsprintf() with safer vsnprintf() in Utils.c to prevent possible buffer overflows in gslogError(), gslogMessage(), and gslogMessagePrefix() functions - Fix incorrect variable references in RSA debug logging which prevents compiling debug code. This results in syntax errors: - Use ciphertextLen instead of plaintextLen in RSA.c - Use keyBytesNative instead of pBytes in RSAKey.c - Improve error handling in ockCheckStatus() by using ICC_ERR_error_string_n() with bounded fixed size buffer. Loop printing exception messages changed to print any error code not just the value `1`. - Remove unused OpenSSLError() function from CCM.c These changes enhance security by preventing the potential of a buffer overflow and fix debug logging to display correct variable values. Fixes IBM#1345 Signed-off-by: Jason Katonica <katonica@us.ibm.com>
jasonkatonica
force-pushed
the
katonica/issue1345/fixvsprintf
branch
from
86bfc1a to
0e98251
Compare
jasonkatonica
requested review from
JinhangZhang,
KostasTsiounis,
johnpeck-us-ibm and
taoliult
JinhangZhang
approved these changes
May 21, 2026
johnpeck-us-ibm
approved these changes
May 21, 2026
This was referenced May 26, 2026
jasonkatonica
added a commit
that referenced
this pull request
May 27, 2026
- Replace unsafe vsprintf() with safer vsnprintf() in Utils.c to prevent possible buffer overflows in gslogError(), gslogMessage(), and gslogMessagePrefix() functions - Fix incorrect variable references in RSA debug logging which prevents compiling debug code. This results in syntax errors: - Use ciphertextLen instead of plaintextLen in RSA.c - Use keyBytesNative instead of pBytes in RSAKey.c - Improve error handling in ockCheckStatus() by using ICC_ERR_error_string_n() with bounded fixed size buffer. Loop printing exception messages changed to print any error code not just the value `1`. - Remove unused OpenSSLError() function from CCM.c These changes enhance security by preventing the potential of a buffer overflow and fix debug logging to display correct variable values. Fixes #1345 Back-ported from: #1484 Signed-off-by: Jason Katonica <katonica@us.ibm.com>
jasonkatonica
added a commit
that referenced
this pull request
May 27, 2026
- Replace unsafe vsprintf() with safer vsnprintf() in Utils.c to prevent possible buffer overflows in gslogError(), gslogMessage(), and gslogMessagePrefix() functions - Fix incorrect variable references in RSA debug logging which prevents compiling debug code. This results in syntax errors: - Use ciphertextLen instead of plaintextLen in RSA.c - Use keyBytesNative instead of pBytes in RSAKey.c - Improve error handling in ockCheckStatus() by using ICC_ERR_error_string_n() with bounded fixed size buffer. Loop printing exception messages changed to print any error code not just the value `1`. - Remove unused OpenSSLError() function from CCM.c These changes enhance security by preventing the potential of a buffer overflow and fix debug logging to display correct variable values. Fixes #1345 Back-ported from: #1484 Signed-off-by: Jason Katonica <katonica@us.ibm.com>
jasonkatonica
added a commit
that referenced
this pull request
May 27, 2026
- Replace unsafe vsprintf() with safer vsnprintf() in Utils.c to prevent possible buffer overflows in gslogError(), gslogMessage(), and gslogMessagePrefix() functions - Fix incorrect variable references in RSA debug logging which prevents compiling debug code. This results in syntax errors: - Use ciphertextLen instead of plaintextLen in RSA.c - Use keyBytesNative instead of pBytes in RSAKey.c - Improve error handling in ockCheckStatus() by using ICC_ERR_error_string_n() with bounded fixed size buffer. Loop printing exception messages changed to print any error code not just the value `1`. - Remove unused OpenSSLError() function from CCM.c These changes enhance security by preventing the potential of a buffer overflow and fix debug logging to display correct variable values. Fixes #1345 Back-ported from: #1484 Signed-off-by: Jason Katonica <katonica@us.ibm.com>
jasonkatonica
added a commit
that referenced
this pull request
May 27, 2026
- Replace unsafe vsprintf() with safer vsnprintf() in Utils.c to prevent possible buffer overflows in gslogError(), gslogMessage(), and gslogMessagePrefix() functions - Fix incorrect variable references in RSA debug logging which prevents compiling debug code. This results in syntax errors: - Use ciphertextLen instead of plaintextLen in RSA.c - Use keyBytesNative instead of pBytes in RSAKey.c - Improve error handling in ockCheckStatus() by using ICC_ERR_error_string_n() with bounded fixed size buffer. Loop printing exception messages changed to print any error code not just the value `1`. - Remove unused OpenSSLError() function from CCM.c These changes enhance security by preventing the potential of a buffer overflow and fix debug logging to display correct variable values. Fixes #1345 Back-ported from: #1484 Signed-off-by: Jason Katonica <katonica@us.ibm.com>
jasonkatonica
added a commit
that referenced
this pull request
May 27, 2026
- Replace unsafe vsprintf() with safer vsnprintf() in Utils.c to prevent possible buffer overflows in gslogError(), gslogMessage(), and gslogMessagePrefix() functions - Fix incorrect variable references in RSA debug logging which prevents compiling debug code. This results in syntax errors: - Use ciphertextLen instead of plaintextLen in RSA.c - Use keyBytesNative instead of pBytes in RSAKey.c - Improve error handling in ockCheckStatus() by using ICC_ERR_error_string_n() with bounded fixed size buffer. Loop printing exception messages changed to print any error code not just the value `1`. - Remove unused OpenSSLError() function from CCM.c These changes enhance security by preventing the potential of a buffer overflow and fix debug logging to display correct variable values. Fixes #1345 Back-ported from: #1484 Signed-off-by: Jason Katonica <katonica@us.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.These changes enhance security by preventing the potential of a buffer overflow and fix debug logging to display correct variable values.
Fixes #1345
Signed-off-by: Jason Katonica katonica@us.ibm.com