Set XEC secret buffer size explicitly on z/OS#1493
Merged
Conversation
taoliult
requested review from
JinhangZhang,
KostasTsiounis,
jasonkatonica and
johnpeck-us-ibm
KostasTsiounis
requested changes
May 27, 2026
Set the expected XEC secret buffer size explicitly on z/OS before calling the native ECDH secret computation. On other platforms, the native layer can query the required secret size by calling ICC_EVP_PKEY_derive. However, this size query does not work on z/OS. To handle this platform difference, determine the curve name from the public key parameters on z/OS and pass the expected secret buffer size to the native layer. Other platforms continue to use the ICC_EVP_PKEY_derive size query. Signed-off-by: Tao Liu <tao.liu@ibm.com>
johnpeck-us-ibm
approved these changes
May 27, 2026
keithc-ca
reviewed
May 29, 2026
| Java_com_ibm_crypto_plus_provider_ock_NativeOCKImplementation_XECKEY_1computeECDHSecret( | ||
| JNIEnv *env, jclass thisObj, jlong ockContextId, jlong genCtx, | ||
| jlong pubXecKeyId, jlong privXecKeyId) { | ||
| jlong pubXecKeyId, jlong privXecKeyId, jint secretBufferSize) { |
Member
There was a problem hiding this comment.
Line 2225 should be updated to reflect the new signature.
Collaborator
Author
There was a problem hiding this comment.
I will open another PR to correct the signature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set the expected XEC secret buffer size explicitly on z/OS before calling the native ECDH secret computation.
On other platforms, the native layer can query the required secret size by calling ICC_EVP_PKEY_derive. However, this size query does not work on z/OS.
To handle this platform difference, determine the curve name from the public key parameters on z/OS and pass the expected secret buffer size to the native layer.
Other platforms continue to use the ICC_EVP_PKEY_derive size query.