-
Notifications
You must be signed in to change notification settings - Fork 1
fix(vllm_performance): Avoid multiple experiments using the same kubernetes deployment at the same time #268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ments in parallel Signed-off-by: Christian Pinto <[email protected]>
…onments Signed-off-by: Christian Pinto <[email protected]>
…oyment Signed-off-by: Christian Pinto <[email protected]>
|
No vulnerabilities found. |
plugins/actuators/vllm_performance/ado_actuators/vllm_performance/deployment_management.py
Outdated
Show resolved
Hide resolved
plugins/actuators/vllm_performance/ado_actuators/vllm_performance/k8s/create_environment.py
Outdated
Show resolved
Hide resolved
plugins/actuators/vllm_performance/ado_actuators/vllm_performance/deployment_management.py
Outdated
Show resolved
Hide resolved
plugins/actuators/vllm_performance/ado_actuators/vllm_performance/deployment_management.py
Outdated
Show resolved
Hide resolved
plugins/actuators/vllm_performance/ado_actuators/vllm_performance/deployment_management.py
Outdated
Show resolved
Hide resolved
plugins/actuators/vllm_performance/ado_actuators/vllm_performance/env_manager.py
Outdated
Show resolved
Hide resolved
plugins/actuators/vllm_performance/ado_actuators/vllm_performance/env_manager.py
Outdated
Show resolved
Hide resolved
plugins/actuators/vllm_performance/ado_actuators/vllm_performance/env_manager.py
Outdated
Show resolved
Hide resolved
plugins/actuators/vllm_performance/ado_actuators/vllm_performance/env_manager.py
Outdated
Show resolved
Hide resolved
plugins/actuators/vllm_performance/ado_actuators/vllm_performance/env_manager.py
Outdated
Show resolved
Hide resolved
|
Also there is an issue, not related to the change where (in the case of one max environment)
Opened #273 to record this. Its rare so we can leave to as a future feature if we find it necessary. |
Signed-off-by: Christian Pinto <[email protected]>
… use Signed-off-by: Christian Pinto <[email protected]>
Signed-off-by: Christian Pinto <[email protected]>
michael-johnston
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on a few scenarios and is working as expected 🚀
Signed-off-by: Christian Pinto <[email protected]>
AlessandroPomponio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just two questions
plugins/actuators/vllm_performance/ado_actuators/vllm_performance/experiment_executor.py
Outdated
Show resolved
Hide resolved
plugins/actuators/vllm_performance/ado_actuators/vllm_performance/env_manager.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Christian Pinto <[email protected]>
|
Checks Summary Last run: 2025-12-03T13:20:54.049Z Code Risk Analyzer vulnerability scan found 2 vulnerabilities:
|
AlessandroPomponio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks


In case a of BS>1 if the entity samples require the same deployment type and there is one running, they will all use it at the same time. This spoils the test results as the experiments interfere with each other.
This PR makes the following changes:
I have done the following tests:
All tests successful.
I have also tested artificially failing one deployment while downloading a model for the first time and other deployments waiting. New Leader kicks in and the process continues
@michael-johnston and/or @AlessandroPomponio please try on your environment.
Example space with 16 entities all requesting the same K8s deployment
Example space with 16 entities requesting 4 K8s deployment
Example space with 16 entities requesting 4 K8s deployment using two different models
sample random walk