fix drain-chain hierarchy for barrier context; convert overlap counter to tracewarning - #120
Merged
Conversation
…r to tracewarning Signed-off-by: Lars Schneidenbach <schneidenbach@us.ibm.com>
lasch
requested review from
Rafael-Sadykov,
WarningRan,
aishwariyachakraborty,
ppnaik1890 and
yuhaohaoyu
as code owners
July 28, 2026 20:17
ppnaik1890
reviewed
Aug 6, 2026
ppnaik1890
left a comment
ppnaik1890
left a comment
Collaborator
There was a problem hiding this comment.
lgtm. just a suggestion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overlap detection stage did still use its own 'counter' to collect info about resolved overlaps.
This PR converts that to actual TraceWarning - streamlining warnings with the rest of the code.
In the process, I noticed that the barrier drain was cutting the chain of calling super-class drain functions and fixed that issue.
Now
super.drain()is called by barrier when itsdrainis called during application phase.Had to update the 'disabled output capture' test and prevent it from capturing non-critical DEBUG-level logging from TraceWarning.