Handle empty deviceProperties during ingestion - #125
Merged
Conversation
nicksunka
requested review from
Rafael-Sadykov,
WarningRan,
aishwariyachakraborty,
lasch,
ppnaik1890 and
yuhaohaoyu
as code owners
August 18, 2026 13:45
Signed-off-by: Nikhil Sunka <NikhilSunka@icloud.com>
nicksunka
force-pushed
the
nikhil/empty-device-properties
branch
from
August 18, 2026 13:47
9fa2861 to
c650662
Compare
Member
|
That empty deviceProperties case is something to look into on the torch side. It will be needed as soon as any attempts for multi-device profiles become relevant and is also something that would get us more feature-parity with GPUs |
Contributor
Author
|
Thanks Lars! Good point - I’ll also look into why deviceProperties is empty on the Torch/PyTorch 2.13 side, especially with the multi-device profiling implications. Thanks for the quick review and merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acelyzer currently assumes incoming deviceProperties contains exactly one entry during metadata merge. Fresh PyTorch 2.13 Spyre traces can contain deviceProperties: [], which causes ingestion to fail before verification runs.
This change allows an empty deviceProperties list while preserving the existing restriction against multiple incoming entries.
Added a regression test covering deviceProperties: [].
Validation: