fix: multi-file ingest name collision - #17
Conversation
Signed-off-by: Lars Schneidenbach <schneidenbach@us.ibm.com>
Interesting. You're explicitly listed as a collaborator and with 'write' level access. According to the description, that includes managing PRs and issues. |
Thanks for checking. That is interesting. I will try to look deeper... |
trent-s
left a comment
There was a problem hiding this comment.
Rereviewing: Still looks good to me. :-)
Sorry for the delay and confusion. Conclusion: User error. I needed more coffee. :-) |
Thanks for digging into this. |
fixing a bug in ingestion:
MultifileIngestand thus prevents subsequent file-specific settings to take effect when e.g. a json file ingester is created.fixing by using a static string. This problem would still trigger if someone uses an input file named
top_level_multifile, though, I'd say it's safe enough because usually input files have.jsonextension or include wildcards.