Skip to content

fix: multi-file ingest name collision - #17

Merged
trent-s merged 1 commit into
IBM:mainfrom
lasch:fix_multifile_ingest
Aug 13, 2025
Merged

fix: multi-file ingest name collision#17
trent-s merged 1 commit into
IBM:mainfrom
lasch:fix_multifile_ingest

Conversation

@lasch

@lasch lasch commented Aug 12, 2025

Copy link
Copy Markdown
Member

fixing a bug in ingestion:

  • if a single file is provided as input, the jobhash+info initialization is shadowed by the construction of MultifileIngest and thus prevents subsequent file-specific settings to take effect when e.g. a json file ingester is created.

fixing by using a static string. This problem would still trigger if someone uses an input file named top_level_multifile, though, I'd say it's safe enough because usually input files have .json extension or include wildcards.

Signed-off-by: Lars Schneidenbach <schneidenbach@us.ibm.com>
@lasch lasch self-assigned this Aug 12, 2025
@lasch lasch added the bug Something isn't working label Aug 12, 2025

@trent-s trent-s left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Though, it looks like I don't have sufficient permission for my review to count... What is the process to request dev access for this repo?

@lasch

lasch commented Aug 13, 2025

Copy link
Copy Markdown
Member Author

Though, it looks like I don't have sufficient permission for my review to count... What is the process to request dev access for this repo?

Interesting. You're explicitly listed as a collaborator and with 'write' level access. According to the description, that includes managing PRs and issues.

@trent-s

trent-s commented Aug 13, 2025

Copy link
Copy Markdown
Member

Interesting. You're explicitly listed as a collaborator and with 'write' level access. According to the description, that includes managing PRs and issues.

Thanks for checking. That is interesting. I will try to look deeper...

@trent-s
trent-s self-requested a review August 13, 2025 01:23

@trent-s trent-s left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rereviewing: Still looks good to me. :-)

@trent-s
trent-s merged commit b234e26 into IBM:main Aug 13, 2025
2 checks passed
@trent-s

trent-s commented Aug 13, 2025

Copy link
Copy Markdown
Member

Thanks for checking. That is interesting. I will try to look deeper...

Sorry for the delay and confusion. Conclusion: User error. I needed more coffee. :-)

@lasch

lasch commented Aug 13, 2025

Copy link
Copy Markdown
Member Author

Sorry for the delay and confusion. Conclusion: User error. I needed more coffee. :-)

Thanks for digging into this.
I wish all SW problems could be fixed with more coffee.

@lasch
lasch deleted the fix_multifile_ingest branch August 13, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants