fix: File enumeration fails on older git binary #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: George Pickering <[email protected]>
Signed-off-by: George Pickering <[email protected]>
Author
|
(looking at tests) |
Signed-off-by: George Pickering <[email protected]>
Signed-off-by: George Pickering <[email protected]>
Signed-off-by: George Pickering <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Info
Closes #148. On systems with older versions of
git(i.e centOS7 in that issue) the-C <path>option is not supported. This flag was added back in1.8.5(git/git@44e1e4d)... And since the error is not getting logged, this results in a silent truncation of the entire.secrets.baselinefile.This PR does two things:
1.8.5via--git-dir <path>/.git