This repository was archived by the owner on Jul 22, 2024. It is now read-only.
Adaptations for Hemnet descriptions / needs renovation#8
Open
Adaptations for Hemnet descriptions / needs renovation#8
Conversation
sg10
commented
Mar 9, 2022
sg10
commented
- add dataset preprocessing
- human oracle (keyboard input labelling)
- Swedish BERT
- adjust constants to avoid BERT OOM
- fix dependency versions
- add dataset preprocessing - human oracle (keyboard input labelling) - Swedish BERT - adjust constants to avoid BERT OOM - fix dependency versions
alonh
reviewed
Mar 10, 2022
Member
alonh
left a comment
alonh
left a comment
There was a problem hiding this comment.
Thanks for using the open source. In general, we want to preserve the existing functionality that reflects the results from the paper. This requires changes to be made a bit differently, namely by adding features and modules rather than changing default values or behaviors. For example, if you want to use PyTorch instead of Tensorflow, you can follow the instructions here.
If you want to enable user input, which is a great idea, please implement it as a different data_access/oracle_data_access so the main experiment code will still be valid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.