-
Couldn't load subscription status.
- Fork 365
feat: ALTK JSON Processing native plugin #1326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
552b307 to
b57bf7b
Compare
| watsonx: | ||
| wx_api_key: "" # optional, can define WX_API_KEY instead | ||
| wx_project_id: "" # optional, can define WX_PROJECT_ID instead | ||
| wx_url: "https://us-south.ml.cloud.ibm.com" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is each section of the providers required? or optional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional, I can mark it as such.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may not want to add this into the config.yaml by default as it will require the optional requirement of altk to be always need to be added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even if the plugin is disabled? What would be the right thing to do then? Separate config.yaml in the plugin directory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what are the implications of removing pyre-check when altk isn't installed? Do all the tests pass?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's supposed to be used in linting but as far as I can tell the current linter list doesn't use it:
Line 841 in fa92384
| LINTERS := isort flake8 pylint mypy bandit pydocstyle pycodestyle pre-commit \ |
Must Fix
Should Fix
|
99da2de to
29c9fab
Compare
|
Addressed feedback in the following ways:
Explain why pyre-check was removed: |
Signed-off-by: Jason Tsay <[email protected]>
Signed-off-by: Jason Tsay <[email protected]>
29c9fab to
c0a34c3
Compare
Summary
LLMs tend to be very poor at parsing long or complex JSON objects. This plugin uses the JSON Processor component from the Agent Lifecycle Toolkit to detect long JSON responses and then parses long responses using a given query.
Notes
This PR adds the
ALTKJsonProcessorplugin as a native plugin. An optional dependency to theagent-lifecycle-toolkitpackage in pypi is added as a optional dependency group. There is a dev dependency conflict withpyre-checkdue to its harddataclasses-json==0.5.7dependency.