feat: #1336 Added toggles on password input textboxes to mask/unmask the entered value. #1337
+131
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aakashH242
requested review from
crivetimihai,
kevalmahajan and
madhav165
as code owners
aakashH242
force-pushed
the
feat/password-mask-toggle
branch
2 times, most recently
from
bd4e218 to
4ec0e02
Compare
aakashH242
changed the title
aakashH242
force-pushed
the
feat/password-mask-toggle
branch
2 times, most recently
from
2da9548 to
4557580
Compare
…unmask the entered value. Signed-off-by: Aakash <[email protected]>
Signed-off-by: Mihai Criveti <[email protected]>
crivetimihai
force-pushed
the
feat/password-mask-toggle
branch
from
4557580 to
31e180d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Aakash [email protected]
✨ Feature / Enhancement PR
🔗 Epic / Issue
Closes #1336
🚀 Summary (1-2 sentences)
Adds a toggle button to unmask/mask the value entered in password textboxes when admins create/edit servers with authentication types - Basic Auth, Bearer Token and Custom Headers.
🧪 Checks
make lintpassesmake testpasses📓 Notes (optional)
Screenshots