Skip to content

Conversation

@hariarla
Copy link
Contributor

PR summary

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Screenshot 2025-10-21 at 11 18 46 PM Screenshot 2025-10-21 at 11 17 54 PM Screenshot 2025-10-21 at 8 39 36 PM

Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments to address before merging. Nothing serious, the core changes look good!

Update: I revisited my comments after reviewing the Node PR and have changed my mind. The PR looks good, the things that I mentioned either not valid or just really minor and not worth to mention. I go ahead and approve this PR then merge it.

@pyrooka pyrooka merged commit d48dd9a into main Oct 27, 2025
16 checks passed
@pyrooka pyrooka deleted the enable_custom_role_templates branch October 27, 2025 16:45
ibm-devx-sdk pushed a commit that referenced this pull request Oct 27, 2025
# [0.70.0](v0.69.0...v0.70.0) (2025-10-27)

### Features

* **IAM Policy Management:** add enterprise custom role ([#307](#307)) ([d48dd9a](d48dd9a))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.70.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants