Minor fixes to installed files for missing header and ROCM search #752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Ragghianti
force-pushed
the
g/install_fix
branch
from
9dbf096 to
36f5328
Compare
devreal
reviewed
Aug 3, 2025
G-Ragghianti
force-pushed
the
g/install_fix
branch
from
36f5328 to
5eb0edd
Compare
G-Ragghianti
force-pushed
the
g/install_fix
branch
from
5eb0edd to
4217c39
Compare
bosilca
approved these changes
Aug 5, 2025
Contributor
Author
|
OK to be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a missing header file to the installation that is required for building against the parsec install.
It also add the
defaultrocm search path/opt/rocmso that an application building against this installation can find the HIP installation when parsec is built with HIP support.