Skip to content

Gallery viewer testing fixes - #64

Merged
will-moore merged 14 commits into
IDR:masterfrom
will-moore:gallery_viewer_testing_fixes
May 27, 2026
Merged

Gallery viewer testing fixes#64
will-moore merged 14 commits into
IDR:masterfrom
will-moore:gallery_viewer_testing_fixes

Conversation

@will-moore

@will-moore will-moore commented May 14, 2026

Copy link
Copy Markdown
Member

Update download_urls page and gallery_viewer pages to fix various links and reduce code logic.
Fixes #63

Instead of complex code, we add all the special case handling to IDR/idr.openmicroscopy.org#220.

This PR needs the table from that PR. We can temporarily specify it by adding it to the query string:

To test:

@will-moore
will-moore force-pushed the gallery_viewer_testing_fixes branch from 578ed95 to e3a7969 Compare May 14, 2026 21:46
@will-moore
will-moore requested a review from dominikl May 18, 2026 11:21
@will-moore

Copy link
Copy Markdown
Member Author

@dom updated this on idr-testing just now.

@dominikl dominikl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Will. Looks good to me! But maybe @francesw could so some random testing too? Easy to miss something.

@francesw

Copy link
Copy Markdown
Member

Tested random selection of non-zarr studies. Download Image Files pages working for them as expected.

@will-moore

Copy link
Copy Markdown
Member Author

As discussed with @dominikl this morning, we will ONLY show images with externalInfo set in iviewer - so we can use that for the is_zarr test.
We can remove the idr0138 exception, since Dom will remove externalInfo from idr0138 (since the data is on file-system that will no-longer be accessible).

@will-moore
will-moore merged commit a9c2b29 into IDR:master May 27, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: idr0003 download urls need resolving

3 participants