Gallery viewer testing fixes - #64
Merged
Merged
Conversation
will-moore
force-pushed
the
gallery_viewer_testing_fixes
branch
from
May 14, 2026 21:46
578ed95 to
e3a7969
Compare
…ls for image and study pages
Member
Author
|
@dom updated this on idr-testing just now. |
Member
|
Tested random selection of non-zarr studies. Download Image Files pages working for them as expected. |
This reverts commit b639201.
Member
Author
|
As discussed with @dominikl this morning, we will ONLY show images with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update download_urls page and gallery_viewer pages to fix various links and reduce code logic.
Fixes #63
Instead of complex code, we add all the special case handling to IDR/idr.openmicroscopy.org#220.
This PR needs the table from that PR. We can temporarily specify it by adding it to the query string:
To test:
client_pathcolumn has a link that is derived from theclient_pathitself, and thereplace thisandwith thiscolumns. The client path text is shown with the derived URL being the link. These links should all be valid (green).GitHubstudies - Does the text/links make sense? The "download" ftp link should be valid (from tsv file) and the companion file link should work, but the tiffs may not for all cases.replace thiscolumns, e.g. idr0145, idr0021 etc.