-
Notifications
You must be signed in to change notification settings - Fork 1
Removed transaction DEV-34 (Announce Network Departure) and updated r… #424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed transaction DEV-34 (Announce Network Departure) and updated r… #424
Conversation
…eferences to future SDPi versions for maintainability
@ToddCooper and @d-gregorczyk @PeterKranich , I think this PR implements all the changes described in the ticket. HOWEVER please check carefully that we are following a good approach to deprecate content (i.e. what to display as reserved) |
@d-gregorczyk @PeterKranich , I am not sure if we ever discussed what should happen to the "Bye" parts of DEV-46 and DEV-47. Should they also be withdrawn? |
SDPi call 11 April 2025: |
IMHO, a Bye message has some advantages but none of them are extremely important:
Altough, the bye message has a security issue with Ad-hoc discovery it is less critical in combination with a discovery proxy since the communiccation is encrypted. I wouldn't mind not to support the bye message right now. |
@PeterKranich - So the question was a few parts:
My sense is that we wanted to do the first approach and not the second BUT add the documentation as indicated. YES? |
@PeterKranich , as I understood it the discussion was about about dropping the
I wonder if multicast hello is problematic too? Any device could send a hello claiming to be some end-point reference but providing a different IP address. Perhaps TLS for the rest of communications takes care of this apparent man-in-the-middle attack. But do we need consumers to ignore any multicast hello message if they are configured to used managed discovery? Potentially ad-hoc |
Great discussion (that keeps widening up!) |
2025-06-06 SDPi call: decision made to complete this PR as proposed (full removal of DEv-34, leaving a note behind). PR details need approvers' checking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All changes reviewed and approved.
@PeterKranich , @ToddCooper @d-gregorczyk , could you please review again for approval? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All changes reviewed and approved.
…eferences to future SDPi versions for maintainability
📑 Description
☑ Mandatory Tasks
The following aspects have been respected by the pull request assignee and at least one reviewer: