Repository navigation
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
demiankatz
left a comment
demiankatz
left a comment
There was a problem hiding this comment.
@dnoneill, the build was failing here due to an unrelated issue. Do you mind merging the latest dev branch into your branch here to get the build passing again?
SearchService2 doesn't have a profile so I want to be able to do this manifest.getService('searchservice2'). This allows the ability to get a service based on type.
|
@demiankatz done |
demiankatz
left a comment
demiankatz
left a comment
There was a problem hiding this comment.
Thanks, @dnoneill!
Do you need us to expedite a release so you can take advantage of this improvement? I'm a bit short on time at the moment, but I can talk to the team and see if anyone is available if there's an urgent need to get this out quickly.
demiankatz
left a comment
demiankatz
left a comment
There was a problem hiding this comment.
Oh, I approved too soon -- Typescript is unhappy about this:
src/Utils.ts(1044,9): error TS2367: This comparison appears to be unintentional because the types 'IIIFResourceType' and 'ServiceProfile' have no overlap.
I think some more work is needed to get the types into a state where this will build without errors. Please let me know if you need help figuring out the specifics!
|
It probably would be wise to add a test case for the new situation as well, to be sure things are working as expected. |
SearchService2 doesn't have a profile so I want to be able to do this manifest.getService('searchservice2'). This allows the ability to get a service based on type.